rmannibucau commented on PR #1231:
URL: https://github.com/apache/maven/pull/1231#issuecomment-1713081100
> using slf4j vs console is completely orthogonal: it does not change
anything to this issue. Don't hesitate to open a Jira and a PR in parallel
Yes and no, using colors does not solve the issue you mention for me, using
loggers is a proposal so somehow it does IMHO.
> we don't have gavce in the API: we can't do that
We can for 2 reasons:
* We own aether
* Worse case a thread local solves that since transport is sadly for now
> effective url base is useful (depends on user settings)
Agree, this is why I said it would be debug level cause most of the time it
is not but if needed it can be enabled with --loggin-level which sounds like
solving the issue you reference for me.
> gavce can't display maven-metadata.xml
Why? you can reference it in the mesage but it stays readable compared to an
url randomized on the output.
> it is already readable without anything else IMHO
Ok, I disagree on that point for the two mentionned reasons
> for sure, it's done as pure color enhancement, absolutely not any other
change: then data exactly is the same, just color to help see the important
different fields and cases
This is why for me it is not better, several cases will not have colors,
contrast will not always make it better - can make it worse btw - and length
stays the same.
> ask a normal user about the difference between "Downloading" and
"Downloaded", ask about the url structure
for you and every Maven developer, there is no problem (just hard to read
output: you need to concentrate to see the different parts)
Feedback I encountered were, rest was either "it is too verbose but I
filtered it after or it was ok":
* It is not readable - note: literally - cause of the output interleaving I
mentionned
* what is the link with my pom (repo in parents)
> I know this output is new and made by someone else: take time to use it
and see live why it was done the way of was done...
I appreciate the proposal but my point is I think it does not address the
referenced ticket at the end - and I'm saying that after being one to think
about that some years ago - was with sed to add colors at that time. Just
trying to ensure we dont mark resolved a ticket we didnt address.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
