[GitHub] [maven] sultan commented on pull request #845: [MNG-7559] Fix versions comparison
sultan commented on PR #845: URL: https://github.com/apache/maven/pull/845#issuecomment-1359307317 > This merge has been reverted on master. A new clean PR was created to reintroduce the fix * PR #929 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] sultan commented on pull request #845: [MNG-7559] Fix versions comparison
sultan commented on PR #845: URL: https://github.com/apache/maven/pull/845#issuecomment-1355512813 @elharo is it wished to port this to 3.9.x branch? if so a PR is available here: * PR #887 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] sultan commented on pull request #845: [MNG-7559] Fix versions comparison
sultan commented on PR #845: URL: https://github.com/apache/maven/pull/845#issuecomment-1330695709 @elharo, fixed javadoc build errors by replacing > with and < with -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] sultan commented on pull request #845: [MNG-7559] Fix versions comparison
sultan commented on PR #845: URL: https://github.com/apache/maven/pull/845#issuecomment-1330623513 made the suggested change, thanks @elharo -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] sultan commented on pull request #845: [MNG-7559] Fix versions comparison
sultan commented on PR #845: URL: https://github.com/apache/maven/pull/845#issuecomment-1330532766 @elharo rebased and applied code styles with spotless plugin -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] sultan commented on pull request #845: [MNG-7559] Fix versions comparison
sultan commented on PR #845: URL: https://github.com/apache/maven/pull/845#issuecomment-1313673933 made 3 changes. * javadoc without the last dot * put back a method that returns a string * fixed test, hopefully -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] sultan commented on pull request #845: [MNG-7559] Fix versions comparison
sultan commented on PR #845: URL: https://github.com/apache/maven/pull/845#issuecomment-1312761182 > My major concern here is that ea and preview are new. Is it simply the case that their natural order already gives the correct results, both before and after this PR? If so, this is fine. ea and preview removed and let treated with natural ordering > I also do not want to expand the public API in this PR. Looking at this code now I see at least one potential refactoring that would change that newly public API. In any case, new public API needs additional thought and discussion. It's a separate issue from fixing this bug. removed the public visibilities -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] sultan commented on pull request #845: [MNG-7559] Fix versions comparison
sultan commented on PR #845: URL: https://github.com/apache/maven/pull/845#issuecomment-1312758877 reverted public visibilities back to the previous private when they were -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] sultan commented on pull request #845: [MNG-7559] Fix versions comparison
sultan commented on PR #845: URL: https://github.com/apache/maven/pull/845#issuecomment-1312749220 > I'm still digging into the other PRs and the existing spec and code. Pleas bear with me. It's been a while since I looked at this, and I need to make sure all the fiddly little bits are straight in my head. no emergency, still available to clarify anything. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] sultan commented on pull request #845: [MNG-7559] Fix versions comparison
sultan commented on PR #845: URL: https://github.com/apache/maven/pull/845#issuecomment-1312748739 thanks for the feedback -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] sultan commented on pull request #845: [MNG-7559] Fix versions comparison
sultan commented on PR #845: URL: https://github.com/apache/maven/pull/845#issuecomment-1312736928 code and documentation on par. waiting for final reviews. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] sultan commented on pull request #845: [MNG-7559] Fix versions comparison
sultan commented on PR #845: URL: https://github.com/apache/maven/pull/845#issuecomment-1312730805 added another test case to prove website documentation right -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] sultan commented on pull request #845: [MNG-7559] Fix versions comparison
sultan commented on PR #845: URL: https://github.com/apache/maven/pull/845#issuecomment-1312576539 * [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] sultan commented on pull request #845: [MNG-7559] Fix versions comparison
sultan commented on PR #845: URL: https://github.com/apache/maven/pull/845#issuecomment-1312572266 code: * PR https://github.com/apache/maven/pull/845 documentation: * PR https://github.com/apache/maven-site/pull/331 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] sultan commented on pull request #845: [MNG-7559] Fix versions comparison
sultan commented on PR #845: URL: https://github.com/apache/maven/pull/845#issuecomment-1304819529 ready for review @michael-o -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] sultan commented on pull request #845: [MNG-7559] Fix versions comparison
sultan commented on PR #845: URL: https://github.com/apache/maven/pull/845#issuecomment-1304817147 added regression test cases -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] sultan commented on pull request #845: [MNG-7559] Fix versions comparison
sultan commented on PR #845: URL: https://github.com/apache/maven/pull/845#issuecomment-1304789299 made the items attribute private with a public getter -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
