[GitHub] [maven-apache-parent] hboutemy edited a comment on pull request #40: [MPOM-244] upload SHA-512 only for source-release to staging repo

2021-10-19 Thread GitBox


hboutemy edited a comment on pull request #40:
URL: 
https://github.com/apache/maven-apache-parent/pull/40#issuecomment-947352858


   reading your comment, it makes me feel that for a very long time, we're 
probably conflating:
   - hash file format for Maven repository format (= hash only, defined by 
Maven repository format and Maven code that reads/writes it)
   - hash file format for Apache distribution


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [maven-apache-parent] hboutemy edited a comment on pull request #40: MPOM-244 upload SHA-512 only for source-release to staging repo

2021-06-02 Thread GitBox


hboutemy edited a comment on pull request #40:
URL: 
https://github.com/apache/maven-apache-parent/pull/40#issuecomment-853323824


   FYI, I tried `mvn -Papache-release deploy` with the sha512 attachments and 
got 
https://repository.apache.org/content/repositories/snapshots/org/apache/apache/24-SNAPSHOT/
   as expected, unwanted 
`apache-24-20210602.192221-85-source-release.zip.sha512.md5` and 
`apache-24-20210602.192221-85-source-release.zip.sha512.sha1` are there, but it 
works


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [maven-apache-parent] hboutemy edited a comment on pull request #40: MPOM-244 upload SHA-512 only for source-release to staging repo

2021-05-21 Thread GitBox


hboutemy edited a comment on pull request #40:
URL: 
https://github.com/apache/maven-apache-parent/pull/40#issuecomment-845737374


   I understand why you need to exclude asc from checksum, if asc was produced 
before checksum
   I don't understand why we need to ensure that asc was produced before 
checksum: if luckily it was not produced yet, let's benefit from that luck, 
isn't it?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [maven-apache-parent] hboutemy edited a comment on pull request #40: MPOM-244 upload SHA-512 only for source-release to staging repo

2021-05-21 Thread GitBox


hboutemy edited a comment on pull request #40:
URL: 
https://github.com/apache/maven-apache-parent/pull/40#issuecomment-845737374


   I understand why you need to exclude asc from checksum, if asc was produced 
before checksum
   I don't understand why we need to ensure that asc was produced before 
checksum: if luckily it was not produced yet, let benefit from chance, isn't it?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org