[GitHub] [maven-apache-parent] kwin commented on pull request #29: [MPOM-247] make minimum POM version configurable via property

2021-02-21 Thread GitBox 


kwin commented on pull request #29:
URL: 
https://github.com/apache/maven-apache-parent/pull/29#issuecomment-782897677


   @rfscholte Are you fine with this PR?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-apache-parent] kwin commented on pull request #29: MPOM-247 make minimum POM version configurable via property

2021-01-03 Thread GitBox 


kwin commented on pull request #29:
URL: 
https://github.com/apache/maven-apache-parent/pull/29#issuecomment-753630724


   I now use `minimalMavenBuildVersion`, but give it a literal default value, 
as property `mavenVersion` is not defined in this scope.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-apache-parent] kwin commented on pull request #29: MPOM-247 make minimum POM version configurable via property

2021-01-03 Thread GitBox 


kwin commented on pull request #29:
URL: 
https://github.com/apache/maven-apache-parent/pull/29#issuecomment-753613437


   @rfscholte Do you have any examples of usages of `mavenVersion`? I would 
like to add some comment to make the differences between the two properties 
clearer. At least in ASF Parent there is no usage of `mavenVersion`.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-apache-parent] kwin commented on pull request #29: MPOM-247 make minimum POM version configurable via property

2021-01-03 Thread GitBox 


kwin commented on pull request #29:
URL: 
https://github.com/apache/maven-apache-parent/pull/29#issuecomment-753609161


   The property name `mavenVersion` was suggested by @slachiewicz, but I am 
open for other suggestions to make the intention clearer. What about 
`mavenRequiredVersionForBuild`?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org