Tibor17 commented on a change in pull request #27: ARCHETYPE-531
URL: https://github.com/apache/maven-archetype/pull/27#discussion_r409799554
##########
File path:
archetype-common/src/main/java/org/apache/maven/archetype/creator/FilesetArchetypeCreator.java
##########
@@ -702,7 +702,9 @@ private void rewriteEARPluginReferences( Plugin plugin,
String rootArtifactId, S
Xpp3Dom configuration = (Xpp3Dom) plugin.getConfiguration();
if ( configuration != null )
{
- Xpp3Dom[] modules = configuration.getChild( "modules"
).getChildren();
+ Xpp3Dom[] modules = configuration.getChild( "modules" ) != null
Review comment:
use a local variable for `configuration.getChild( "modules" )`.
That's better than this and better for debugging as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
