[GitHub] [maven-archetype] ripper2hl commented on a change in pull request #36: Add feature to create base dir

[GitBox]

ripper2hl commented on a change in pull request #36: Add feature to create base 
dir
URL: https://github.com/apache/maven-archetype/pull/36#discussion_r409962351
 
 

 ##
 File path: 
archetype-common/src/main/java/org/apache/maven/archetype/ArchetypeGenerationRequest.java
 ##
 @@ -390,4 +392,16 @@ public ArchetypeGenerationRequest setFilter( String 
filter )
 
 return this;
 }
+
+public boolean isCreateBaseDir()
+{
+return createBaseDir;
+}
+
+public ArchetypeGenerationRequest setCreteBaseDir( boolean createBaseDir )
 
 Review comment:
   @michael-o you can review now, please


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [maven-archetype] ripper2hl commented on a change in pull request #36: Add feature to create base dir

[GitBox]

ripper2hl commented on a change in pull request #36: Add feature to create base 
dir
URL: https://github.com/apache/maven-archetype/pull/36#discussion_r409904662
 
 

 ##
 File path: 
archetype-common/src/main/java/org/apache/maven/archetype/ArchetypeGenerationRequest.java
 ##
 @@ -390,4 +392,16 @@ public ArchetypeGenerationRequest setFilter( String 
filter )
 
 return this;
 }
+
+public boolean isCreateBaseDir()
+{
+return createBaseDir;
+}
+
+public ArchetypeGenerationRequest setCreteBaseDir( boolean createBaseDir )
 
 Review comment:
   :o  yes, i need fix it , 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [maven-archetype] ripper2hl commented on a change in pull request #36: Add feature no create base dir

[GitBox]

ripper2hl commented on a change in pull request #36: Add feature no create base 
dir
URL: https://github.com/apache/maven-archetype/pull/36#discussion_r374883848
 
 

 ##
 File path: 
archetype-common/src/main/java/org/apache/maven/archetype/generator/DefaultFilesetArchetypeGenerator.java
 ##
 @@ -136,7 +136,8 @@ public void generateArchetype( ArchetypeGenerationRequest 
request, File archetyp
 
 String packageName = request.getPackage();
 String artifactId = request.getArtifactId();
-File outputDirectoryFile = new File( request.getOutputDirectory(), 
artifactId );
+File outputDirectoryFile = new File( request.getOutputDirectory(),
 
 Review comment:
   `request.getOutputDirectory() ` return a String 
   
   If i use your code , needs a bit change
   
   ```java
   File outputDirectoryFile = request.isCreateBaseDir() ? new File( 
request.getOutputDirectory(), artifactId):  new File( 
request.getOutputDirectory() ) ;
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services