[GitHub] [maven-build-cache-extension] AlexanderAshitkin commented on pull request #30: [MBUILDCACHE-24] - Fixes IllegalArgumentException in forked executions
AlexanderAshitkin commented on PR #30: URL: https://github.com/apache/maven-build-cache-extension/pull/30#issuecomment-1383048755 > Hi, I am stumbling on this issue when using either the `1.0.0` or the `1.0.0-SNAPSHOT` version of the maven build cache extension. I have created a small sample project to reproduce the issue I am facing [here ](https://github.com/athkalia/maven-build-cache-forked-executions). Hi @athkalia Thanks a lot for the reproducing project! I will try to fix the issue nearest time. But to be clear, so far cache works for lifecycle executions, not individual plugin goals. So fix will only allow running the command `com.athkalia:module-1:level0` but this execution will not be cached. The cache will be applied only to the regular root project build eg `clean install` I created [MBUILDCACHE-38](https://issues.apache.org/jira/browse/MBUILDCACHE-38) and fix will be provided under that ticket Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-build-cache-extension] AlexanderAshitkin commented on pull request #30: [MBUILDCACHE-24] - Fixes IllegalArgumentException in forked executions
AlexanderAshitkin commented on PR #30: URL: https://github.com/apache/maven-build-cache-extension/pull/30#issuecomment-1380520600 > reproduce -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-build-cache-extension] AlexanderAshitkin commented on pull request #30: [MBUILDCACHE-24] - Fixes IllegalArgumentException in forked executions
AlexanderAshitkin commented on PR #30: URL: https://github.com/apache/maven-build-cache-extension/pull/30#issuecomment-1289338778 @gnodet @maximilian-novikov-db Please review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-build-cache-extension] AlexanderAshitkin commented on pull request #30: [MBUILDCACHE-24] - Fixes IllegalArgumentException in forked executions
AlexanderAshitkin commented on PR #30: URL: https://github.com/apache/maven-build-cache-extension/pull/30#issuecomment-1289185657 > How are `EventSpy` and `BuildCacheMojosExecutionStrategy` related ? I haven't traced it down and so far do not understand how exactly it interferes, but everything points to Guice initialization lifecycle. As I understand, adding `EventSpy` forces earlier forces earlier resolution in extension realm. After that for some reason `BuildCacheMojosExecutionStrategy` strategy is not picked up and build continues with default non-caching strategy. It could be reproduced in master branch with 2 steps: * delete `CacheLifecycleParticipant` (to avoid circular dependency conflict) * make `LifecyclePhasesHelper` extend `AbstractEventSpy` Expected: `BuildExtensionTest` starts failing failing because cache is not intialized If there is a proper way to resolve this - I'm happily ready to pick it up -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-build-cache-extension] AlexanderAshitkin commented on pull request #30: [MBUILDCACHE-24] - Fixes IllegalArgumentException in forked executions
AlexanderAshitkin commented on PR #30: URL: https://github.com/apache/maven-build-cache-extension/pull/30#issuecomment-128901 > I'd like to start a release of `maven-build-cache-extension` this week after merging #29. @AlexanderAshitkin Is this PR something you want in this first release ? HI. So, current situation is that plugin falls with error for a number of popular plugins (pod and spot bugs among them). I think we need fix this before releasing first version. The fix looks pretty safe for me, but it requires to get execution events which are only available in "core extension mode". In "build extension" mode `EventSpyDispatcher` is not available to extension and it is not possible to subscribe for events easily. If I add EventSpy into extension, it disables cache because `BuildCacheMojosExecutionStrategy` is not discovered by guide. So I'm trying to find solution which will allow to run extension in both modes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
