[GitHub] [maven-checkstyle-plugin] eolivelli commented on issue #24: [MCHECKSTYLE-384] Update IT tests to support checkstyle 8.28

2020-02-06 Thread GitBox
eolivelli commented on issue #24: [MCHECKSTYLE-384] Update IT tests to support 
checkstyle 8.28
URL: 
https://github.com/apache/maven-checkstyle-plugin/pull/24#issuecomment-582853379
 
 
   merged as e1e2f28620e2baed8351fea5fa524e98749df55c
   
   thank you @hazendaz 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven-checkstyle-plugin] eolivelli commented on issue #24: [MCHECKSTYLE-384] Update IT tests to support checkstyle 8.28

2020-02-06 Thread GitBox
eolivelli commented on issue #24: [MCHECKSTYLE-384] Update IT tests to support 
checkstyle 8.28
URL: 
https://github.com/apache/maven-checkstyle-plugin/pull/24#issuecomment-582839031
 
 
   I did not rebase and squash all of the commits.
   I have re-launched CI
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven-checkstyle-plugin] eolivelli commented on issue #24: [MCHECKSTYLE-384] Update IT tests to support checkstyle 8.28

2020-02-06 Thread GitBox
eolivelli commented on issue #24: [MCHECKSTYLE-384] Update IT tests to support 
checkstyle 8.28
URL: 
https://github.com/apache/maven-checkstyle-plugin/pull/24#issuecomment-582839070
 
 
   
https://builds.apache.org/job/maven-box/job/maven-checkstyle-plugin/job/MCHECKSTYLE-384/


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven-checkstyle-plugin] eolivelli commented on issue #24: [MCHECKSTYLE-384] Update IT tests to support checkstyle 8.28

2020-02-05 Thread GitBox
eolivelli commented on issue #24: [MCHECKSTYLE-384] Update IT tests to support 
checkstyle 8.28
URL: 
https://github.com/apache/maven-checkstyle-plugin/pull/24#issuecomment-582776768
 
 
   Waiting for CI
   
https://builds.apache.org/job/maven-box/job/maven-checkstyle-plugin/job/MCHECKSTYLE-384/


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven-checkstyle-plugin] eolivelli commented on issue #24: [MCHECKSTYLE-384] Update IT tests to support checkstyle 8.28

2020-02-05 Thread GitBox
eolivelli commented on issue #24: [MCHECKSTYLE-384] Update IT tests to support 
checkstyle 8.28
URL: 
https://github.com/apache/maven-checkstyle-plugin/pull/24#issuecomment-582775959
 
 
   I am going to accept this PR and then bump checkstyle to 8.29.
   I see github started complaining about checkstyle over every project that is 
using checkstyle maven plugin


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven-checkstyle-plugin] eolivelli commented on issue #24: [MCHECKSTYLE-384] Update IT tests to support checkstyle 8.28

2020-01-22 Thread GitBox
eolivelli commented on issue #24: [MCHECKSTYLE-384] Update IT tests to support 
checkstyle 8.28
URL: 
https://github.com/apache/maven-checkstyle-plugin/pull/24#issuecomment-577393358
 
 
   @romano I understand.
   It si a very food motivazione.
   Se shuold chance the JIRA totale andrĂ  the PR totale.
   
   @hazendas what do you think?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [maven-checkstyle-plugin] eolivelli commented on issue #24: [MCHECKSTYLE-384] Update IT tests to support checkstyle 8.28

2020-01-20 Thread GitBox
eolivelli commented on issue #24: [MCHECKSTYLE-384] Update IT tests to support 
checkstyle 8.28
URL: 
https://github.com/apache/maven-checkstyle-plugin/pull/24#issuecomment-576349042
 
 
   I am not sure we should merge this change now that we are cutting 3.1.1
   this release wants to open the way to using latest Checkstyle but without 
updating checkstyle itself


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services