romani edited a comment on issue #5: [MCHECKSTYLE-353] - Don't resolve any
dependencies
URL:
https://github.com/apache/maven-checkstyle-plugin/pull/5#issuecomment-487801254
I am not really sure about correctness of integration tests, I am not sure
what they test. IllegalThrows is not AbstractTypeAwareCheck like
https://github.com/checkstyle/checkstyle/blob/master/src/main/java/com/puppycrawl/tools/checkstyle/checks/javadoc/JavadocMethodCheck.java#L50
if want to test that old Checks that use to work with classpath ( deprecated
feature in checkstyle) are keep running with crashing.
But I can confirm that checkstyle do not support validation based on
classpath, so no dependency resolution is required for validation.
The only dependencies possible is artifacts with custom Checks.
I ok with such changes.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services