[GitHub] [maven-compiler-plugin] pzygielo commented on pull request #153: [MCOMPILER-457] Warn about warn-config conflicting values
pzygielo commented on PR #153: URL: https://github.com/apache/maven-compiler-plugin/pull/153#issuecomment-1335567397 May I ask for review, please? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-compiler-plugin] pzygielo commented on pull request #153: [MCOMPILER-457] Warn about warn-config conflicting values
pzygielo commented on PR #153: URL: https://github.com/apache/maven-compiler-plugin/pull/153#issuecomment-1327514243 > maybe we should simply change `showWarnings` to `true` per default as described in MCOMPILER-457? - Doing so in apache/maven-compiler-plugin#157 - What about THIS change? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-compiler-plugin] pzygielo commented on pull request #153: [MCOMPILER-457] Warn about warn-config conflicting values
pzygielo commented on PR #153: URL: https://github.com/apache/maven-compiler-plugin/pull/153#issuecomment-1326375665 Is there any change requested here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-compiler-plugin] pzygielo commented on pull request #153: [MCOMPILER-457] Warn about warn-config conflicting values
pzygielo commented on PR #153: URL: https://github.com/apache/maven-compiler-plugin/pull/153#issuecomment-1302396964 I didn't want to change currently implemented logic. MCOMPILER-457 happened to me as well. Caused some... confusion. For future me, that does not remember that, it'd be fine to be warned about strange plugin set up. > Maybe when `failOnWarning` is true we also need to change `showWarnings` to true. Maybe. I'd like to have the warning at least in such case as well, that parameter is updated out of my control. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-compiler-plugin] pzygielo commented on pull request #153: [MCOMPILER-457] Warn about warn-config conflicting values
pzygielo commented on PR #153: URL: https://github.com/apache/maven-compiler-plugin/pull/153#issuecomment-1301766219 May I ask for review, please? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
