[GitHub] [maven-compiler-plugin] slawekjaranowski commented on pull request #160: [MCOMPILER-515] This plugin is not "incremental"

2022-12-13 Thread GitBox


slawekjaranowski commented on PR #160:
URL: 
https://github.com/apache/maven-compiler-plugin/pull/160#issuecomment-1348588366

   # Master 
   commit 5be316391ea7c575ee65c3fe83b4c7b30e1174d0
   
   ## Result 1
   
   - next execution - rebuild is skipped
   
   ```
   [INFO] Total time:  01:12 min
   ```
   
   ## Result 2
   
   - after clean
   
   ```
   [INFO] Total time:  05:42 min
   ```
   
   # PR 160
   commit 7b59074b400974b57e9c4cd84269acd39d7a7f9a
   
   Only scenario 2, many times the same command - `mvn test-compile` on the 
same workspace,
   all modules are recompiled everytime,  sample of time:
   
   ```
   [INFO] Total time:  06:25 min
   [INFO] Total time:  05:34 min
   [INFO] Total time:  05:24 min
   ```
   
   take similar time like `mvn clean ...` in my case
   
   so difference from 1 to 5 minutes is important for project which I work at 
usual day, and many time I need to rebuild
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-compiler-plugin] slawekjaranowski commented on pull request #160: [MCOMPILER-515] This plugin is not "incremental"

2022-12-13 Thread GitBox


slawekjaranowski commented on PR #160:
URL: 
https://github.com/apache/maven-compiler-plugin/pull/160#issuecomment-1348400184

   My test 
   
   - Classes in target prod and unit: 4883
   - Maven modules: 326
   - JDK 1.8
   - Os: MacOs 12.6.1 - 2,6 GHz 6-Core Intel Core i7, 32 GB 2667 MHz DDR4
   - m-c-p 3.10.1
   
   
   # Scenario 1
   
   ```
   mvn test-compile
   mvn test-compile | grep -e "Nothing to compile\|Changes detected\|Total 
time" > 1.txt
   ```
   
   # Scenario 2
   
   ```
   mvn clean
   mvn test-compile | grep -e "Nothing to compile\|Changes detected\|Total 
time" > 2.txt
   ```
   
   # Result 1
   
   ```
   grep "Changes detected" 1.txt | wc -l
  1
   
grep "Nothing to compile" 1.txt | wc -l
313
   
   [INFO] Total time:  01:02 min
   ```
   
   # Result 2
   
   ```
   grep "Changes detected" 2.txt | wc -l
314
   
   grep "Nothing to compile" 2.txt | wc -l
  0
   
   [INFO] Total time:  05:59 min
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-compiler-plugin] slawekjaranowski commented on pull request #160: [MCOMPILER-515] This plugin is not "incremental"

2022-12-12 Thread GitBox


slawekjaranowski commented on PR #160:
URL: 
https://github.com/apache/maven-compiler-plugin/pull/160#issuecomment-1347454415

   Also -1 from me. 
   
   Maybe it is not incremental compile - but detecting if module should be 
recompiled.
   
   Detecting on change for project configuration should be fixed instead.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org