[GitHub] [maven-ear-plugin] mabrarov commented on a change in pull request #29: [MEAR-292] skipClassPathModification in case of undefined Class-Path entry of MANFIEST.mf

2020-12-20 Thread GitBox 


mabrarov commented on a change in pull request #29:
URL: https://github.com/apache/maven-ear-plugin/pull/29#discussion_r546406382



##
File path: src/it/skinny-wars-javaee5/ear-module/pom.xml
##
@@ -33,9 +33,26 @@ under the License.
   commons-lang

Review comment:
   Changed version to 2.6 in 83fd4ff





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-ear-plugin] mabrarov commented on a change in pull request #29: [MEAR-292] skipClassPathModification in case of undefined Class-Path entry of MANFIEST.mf

2020-12-20 Thread GitBox 


mabrarov commented on a change in pull request #29:
URL: https://github.com/apache/maven-ear-plugin/pull/29#discussion_r546397158



##
File path: src/it/skinny-wars-javaee5/ear-module/pom.xml
##
@@ -33,9 +33,26 @@ under the License.
   commons-lang

Review comment:
   The latest version of Apache Commons Lang which supports Java 7 is 
[3.8.1](https://commons.apache.org/proper/commons-lang/changes-report.html#a3.9)
 but not 2.6





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-ear-plugin] mabrarov commented on a change in pull request #29: [MEAR-292] skipClassPathModification in case of undefined Class-Path entry of MANFIEST.mf

2020-12-20 Thread GitBox 


mabrarov commented on a change in pull request #29:
URL: https://github.com/apache/maven-ear-plugin/pull/29#discussion_r546397158



##
File path: src/it/skinny-wars-javaee5/ear-module/pom.xml
##
@@ -33,9 +33,26 @@ under the License.
   commons-lang

Review comment:
   The latest version of Apache Commons Lang which supports Java 7 is 
[3.8.1](https://commons.apache.org/proper/commons-lang/changes-report.html#a3.9)
 and not 2.6





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-ear-plugin] mabrarov commented on a change in pull request #29: [MEAR-292] skipClassPathModification in case of undefined Class-Path entry of MANFIEST.mf

2020-12-20 Thread GitBox 


mabrarov commented on a change in pull request #29:
URL: https://github.com/apache/maven-ear-plugin/pull/29#discussion_r546387830



##
File path: src/main/java/org/apache/maven/plugins/ear/EarMojo.java
##
@@ -816,12 +816,15 @@ private void changeManifestClasspath( EarModule module, 
File original, JavaEEVer
 Attribute classPath = mf.getMainSection().getAttribute( 
"Class-Path" );
 List classPathElements = new ArrayList();
 
+boolean classPathExisted;

Review comment:
   Renamed to `classPathExists` in 3b0e65e





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-ear-plugin] mabrarov commented on a change in pull request #29: [MEAR-292] skipClassPathModification in case of undefined Class-Path entry of MANFIEST.mf

2020-12-20 Thread GitBox 


mabrarov commented on a change in pull request #29:
URL: https://github.com/apache/maven-ear-plugin/pull/29#discussion_r546387718



##
File path: src/it/skinny-wars-javaee5/ear-module/pom.xml
##
@@ -33,9 +33,26 @@ under the License.
   commons-lang
   2.5
 
+
+  org.apache.commons
+  commons-lang3
+  3.11

Review comment:
   Replaced with `org.apache.commons:commons-collections4:4.2` in 3b0e65e





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-ear-plugin] mabrarov commented on a change in pull request #29: [MEAR-292] skipClassPathModification in case of undefined Class-Path entry of MANFIEST.mf

2020-12-20 Thread GitBox 


mabrarov commented on a change in pull request #29:
URL: https://github.com/apache/maven-ear-plugin/pull/29#discussion_r546385292



##
File path: src/it/skinny-wars-javaee5/ear-module/pom.xml
##
@@ -33,9 +33,26 @@ under the License.
   commons-lang

Review comment:
   Why should version be 2.6? According to [Apache Commons Lang Release 
Notes](https://commons.apache.org/proper/commons-lang/changes-report.html) 2.5 
version supports Java 7 and 2.6 version doesn't differ from 2.5 version in 
terms of supported Java version.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org