[GitHub] [maven-enforcer] KroArtem commented on pull request #86: [MENFORCER-376] Add excludes/includes functionality to RequireJavaVendor rule
KroArtem commented on pull request #86: URL: https://github.com/apache/maven-enforcer/pull/86#issuecomment-784860238 Based on a discussion in JIRA ticket, this PR should be reworked to support either excludes or includes, not both at the same time. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-enforcer] KroArtem commented on pull request #86: [MENFORCER-376] Add excludes/includes functionality to RequireJavaVendor rule
KroArtem commented on pull request #86: URL: https://github.com/apache/maven-enforcer/pull/86#issuecomment-784309551 @hboutemy , I see that you're also requested for a review, do you have any review comments? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-enforcer] KroArtem commented on pull request #86: [MENFORCER-376] Add excludes/includes functionality to RequireJavaVendor rule
KroArtem commented on pull request #86: URL: https://github.com/apache/maven-enforcer/pull/86#issuecomment-773508958 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-enforcer] KroArtem commented on pull request #86: [MENFORCER-376] Add excludes/includes functionality to RequireJavaVendor rule
KroArtem commented on pull request #86: URL: https://github.com/apache/maven-enforcer/pull/86#issuecomment-773604746 I may be silly but these changes ARE in the PR right now, still don't get what else should be done. Here is where changes are: https://github.com/apache/maven-enforcer/pull/86/files#diff-b2cfcc9c03ff6b43bade73782c36c14b900b63cb39f57bea78a40a6cf62ae259R33 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-enforcer] KroArtem commented on pull request #86: [MENFORCER-376] Add excludes/includes functionality to RequireJavaVendor rule
KroArtem commented on pull request #86: URL: https://github.com/apache/maven-enforcer/pull/86#issuecomment-773563518 > The docs that support this feature should be added in this PR as well. @elharo , what exactly do you mean? I've already made corresponding changes in .apt.vm files. Is there something that should be updated too? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-enforcer] KroArtem commented on pull request #86: [MENFORCER-376] Add excludes/includes functionality to RequireJavaVendor rule
KroArtem commented on pull request #86: URL: https://github.com/apache/maven-enforcer/pull/86#issuecomment-773508958 @rfscholte , @bmarwell , @elharo , can I kindly ask you to review MR again? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-enforcer] KroArtem commented on pull request #86: [MENFORCER-376] Add excludes/includes functionality to RequireJavaVendor rule
KroArtem commented on pull request #86: URL: https://github.com/apache/maven-enforcer/pull/86#issuecomment-770444673 I still have one question, what should happen if I define a list of `includes` but current vendor doesn't satisfy this list? With this implementation it doesn't fail. However, it seem to be aligned with `bannedPlugins` [rule](https://maven.apache.org/enforcer/enforcer-rules/bannedPlugins.html), citing it: ``` includes - a list of plugin artifacts to include. These are exceptions to the excludes. It is meant to allow wide exclusion rules with wildcards and fine tune using includes. If nothing has been excluded, then the includes have no effect. In otherwords, includes only subtract from artifacts that matched an exclude rule. ``` That's the only question left so far. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
