kwin commented on PR #279: URL: https://github.com/apache/maven-enforcer/pull/279#issuecomment-1623254717
> one missing `isWarnOrErrorEnabled` I would prefer to leave that out, as the semantics is not clear from the name. It could mean both 1. `isWarnEnabled() || isErrorEnabled()` or 2. `isWarnEnabled() && rule.getLevel() == EnforcerLevel.WARN || isErrorEnabled() && rule.getLevel() == EnforcerLevel.ERROR` Although one could clarify that in the javadoc the chance for misinterpretation is quite high and I would not add it until we see a real use case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
