[GitHub] [maven-javadoc-plugin] michael-o commented on a diff in pull request #164: MJAVADOC-731 update parent, get rid of legacy

2022-09-19 Thread GitBox


michael-o commented on code in PR #164:
URL: 
https://github.com/apache/maven-javadoc-plugin/pull/164#discussion_r974509735


##
src/main/java/org/apache/maven/plugins/javadoc/resolver/ResourceResolver.java:
##
@@ -415,14 +412,15 @@ private Collection resolveAndUnpack( final 
List artifacts,
 if ( propagateErrors )
 {
 throw new ArtifactResolutionException( "Failed to retrieve 
valid un-archiver component: "
-+ a.getType(), a, e );
++ a.getExtension(), RepositoryUtils.toArtifact( a ), e 
);
 }
 }
 catch ( final ArchiverException e )
 {
 if ( propagateErrors )
 {
-throw new ArtifactResolutionException( "Failed to unpack: 
" + a.getId(), a, e );
+throw new ArtifactResolutionException( "Failed to unpack: 
" + a.toString(),

Review Comment:
   `toString()` will be automatically invoked.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-javadoc-plugin] michael-o commented on a diff in pull request #164: MJAVADOC-731 update parent, get rid of legacy

2022-09-19 Thread GitBox


michael-o commented on code in PR #164:
URL: 
https://github.com/apache/maven-javadoc-plugin/pull/164#discussion_r974509182


##
src/main/java/org/apache/maven/plugins/javadoc/resolver/ResourceResolver.java:
##
@@ -19,26 +19,29 @@
  * under the License.
  */
 
+

Review Comment:
   Seems like one empty line too much...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org