[GitHub] [maven-jlink-plugin] bmhm commented on a change in pull request #9: [MJLINK-50] -Upgrade to Java 11

2020-10-29 Thread GitBox 


bmhm commented on a change in pull request #9:
URL: https://github.com/apache/maven-jlink-plugin/pull/9#discussion_r513802569



##
File path: pom.xml
##
@@ -66,8 +66,7 @@
 
   
 3.0
-1.7
-1.7
+11

Review comment:
   But jlink doesn't come with java 8?





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-jlink-plugin] bmhm commented on a change in pull request #9: [MJLINK-50] -Upgrade to Java 11

2020-10-28 Thread GitBox 


bmhm commented on a change in pull request #9:
URL: https://github.com/apache/maven-jlink-plugin/pull/9#discussion_r513802569



##
File path: pom.xml
##
@@ -66,8 +66,7 @@
 
   
 3.0
-1.7
-1.7
+11

Review comment:
   But jlink doesn't come with java 8?





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org