[GitHub] [maven-mvnd] aalmiray commented on pull request #574: Refactor build and release workflows
aalmiray commented on PR #574: URL: https://github.com/apache/maven-mvnd/pull/574#issuecomment-1093379215 Once merged, the `early-access.yml` workflow will kick in and generate a prerelease title "Release early-access" with the latest binaries. This is independent of the Apache Maven release process. Then, for a regular release, a release candidate must be voted. Manually trigger the `release-candidate-stage1.yml` workflow to generate the binaries. This workflow creates a git release in prerelase mode if not mistaken. Once the vote passes then manually trigger the `release.yml` workflow. **BUT** before you do trigger please review the settings for Homebrew and Sdkman. A personal Git access token is required to push the formula to the target Git repository. My suggestion would be to merge this PR and let the early-access release do its work. We can then discuss the steps to post a release following the Apache Maven release process (of which I've never been a party of). We might need the help of an Apache Maven guide (@hboutemy?) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-mvnd] aalmiray commented on pull request #574: Refactor build and release workflows
aalmiray commented on PR #574: URL: https://github.com/apache/maven-mvnd/pull/574#issuecomment-1088026094 @ppalaga @gnodet I've refreshed this PR with latest changes from `master`. Do you have some time to review the proposed changes? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-mvnd] aalmiray commented on pull request #574: Refactor build and release workflows
aalmiray commented on pull request #574: URL: https://github.com/apache/maven-mvnd/pull/574#issuecomment-1019170686 PR is ready for review. **Notes:** - publication to Homebrew requires a Github Personal access Token with write access to the `mvndaemon` organization. Currently the secrete name is expected to be `GIT_ACCESS_TOKEN`. - Chocolatey publication is not yet configured as an account & API key is required. this account should be set up and owned by someone in the mvnd team (@ppalaga, @gnodet). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-mvnd] aalmiray commented on pull request #574: Refactor build and release workflows
aalmiray commented on pull request #574: URL: https://github.com/apache/maven-mvnd/pull/574#issuecomment-1012086210 Have to release JReleaser 1.0.0-M1 before this PR may be merged. The release should happen within the next 2 weeks. In the meantime, let me know of any adjustments should be made. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-mvnd] aalmiray commented on pull request #574: Refactor build and release workflows
aalmiray commented on pull request #574: URL: https://github.com/apache/maven-mvnd/pull/574#issuecomment-1010331988 Refactored workflows after testing some settings that were not properly working. * `verify.yaml` renamed to `early-access.yml`. * there's now a 2 stage `release-candidate` workflow that's triggered manually. stage1 builds, updates version, and tags (using the release plugin). stage 2 creates the Git release with changelog on tag. The split lets the release master perform stag1 manually if they so choose so, while stage2 it's triggered automatically when the tag is pushed. * `release` workflow builds binaries and updates the existing release. Note the use of a `GIT_ACCESS_TOKEN` secret, this is a PAT required to trigger stage2 by stage1, also to push the brew formula to the given repository. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-mvnd] aalmiray commented on pull request #574: Refactor build and release workflows
aalmiray commented on pull request #574:
URL: https://github.com/apache/maven-mvnd/pull/574#issuecomment-1009924585
OK, I can adjust the workflows to make use of a tag trigger for
`release-candidate`.
If `release:prepare` were to be invoked by a GH workflow then we'll need to
reuse the custom GitHub Personal Access token, as otherwise a tag created with
workflow A won't trigger workflow B, that is, the default `${{
secrets.GITHUB_TOKEN }}` is not enough in this case.
Is that acceptable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-mvnd] aalmiray commented on pull request #574: Refactor build and release workflows
aalmiray commented on pull request #574: URL: https://github.com/apache/maven-mvnd/pull/574#issuecomment-1009806534 Got it. But you do raise a point with moving the version to the next available number and publishing artifacts to Maven Central. Version bump can happen with the `versions` plugin in which case you must set the number. Same goes by setting next snapshot. At least 2 different invocations of mvn. The `release` plugin does this for you in 1 invocation (assuming build success). If mvnd does not deploy artifacts to Maven Central then the release plugin may still be used for handling the numbering scheme while disabling the deploy phase so that no artifacts are pushed to MC, isn't that the case? So we have a few options: - use the maven release plugin. it'll set the version to release, tag, bump version to next. the tag triggers the release-candidate workflow which only creates the git release with changelog. - use manual steps with versions plugin to set the version. JReleaser tags and creates git release with changelog. you may or may not bump the version to next, again using the versions plugin. Both options may be triggered from GH actions, matter of fact I'd say it's a must for option 2. Option 1. can still be triggered locally by the release master as the release-candidate workflow would have a tag trigger that does not care of the tag was made locally or on CI. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-mvnd] aalmiray commented on pull request #574: Refactor build and release workflows
aalmiray commented on pull request #574: URL: https://github.com/apache/maven-mvnd/pull/574#issuecomment-1009778384 Right. If the maven release plugin is used then a tag and a new version will be already set. The release-candidate workflow would have to be changed to be triggered on tag creation and keep JReleaser from creating a tag (as it's already there). If the release-candidate workflow were the starting point then you'd have to change version from snapshot to release (in all poms), let JReleaser create the tag (or explicit tag in the workflow), issue a deploy to Maven Central (not using the release plugin), and to be honest it already sounds complicated, at least to me. Starting the release process with the maven release plugin, having the release-candidate be triggered on tag creation sounds better to me from a minimalistic automation POV, less moving parts IMHO. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-mvnd] aalmiray commented on pull request #574: Refactor build and release workflows
aalmiray commented on pull request #574: URL: https://github.com/apache/maven-mvnd/pull/574#issuecomment-1008747503 > Id vote for triggering by a tag, but how about the third option: let release-candidate create the tag itself? This is of course possible but here I wonder how will the workflow interact with the Apache Maven release process? I'm not familiar with it so that's why I did not push to automate that part just yet. Who and when is responsible for tagging a repository before a vote is started? If the tag happens earlier in the process and IF this workflow creates the tag then the changelog will be ready before the e-mail vote is sent, right? Perhaps @hboutemy may help us clarify this point 😄 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-mvnd] aalmiray commented on pull request #574: Refactor build and release workflows
aalmiray commented on pull request #574: URL: https://github.com/apache/maven-mvnd/pull/574#issuecomment-1008034586 Added Homebrew and Sdkman configuration Both `release-candidate` and `release` workflows expect that a tag has been already created (following the Apache release process) and thus they must be triggered manually. If you feel like `release-candidate` should be triggered with a tag then we can update the trigger condition. However the `release` workflow may remain with a manual trigger as it should only be run once a vote has been successfully passed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
