[GitHub] [maven-project-info-reports-plugin] belingueres commented on pull request #47: [MPIR-431] Dependency file details section: segregate Java version
belingueres commented on PR #47: URL: https://github.com/apache/maven-project-info-reports-plugin/pull/47#issuecomment-1570379127 I'll try to work on a PR if not too complex. > > We could fix the error by taking the same scope than its parent dependency AND logging a warning. It is warranted to eventually succeed since direct dependencies must have a correct scope (otherwise the project's pom.xml won't pass the validation phase) > >  > > Sounds good. Do you want to work on a PR? I'll give it a try -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-project-info-reports-plugin] belingueres commented on pull request #47: [MPIR-431] Dependency file details section: segregate Java version
belingueres commented on PR #47: URL: https://github.com/apache/maven-project-info-reports-plugin/pull/47#issuecomment-1569452467 We could fix the error by taking the same scope than its parent dependency AND logging a warning. It is warranted to eventually succeed since direct dependencies must have a correct scope (otherwise the project's pom.xml won't pass the validation phase)  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-project-info-reports-plugin] belingueres commented on pull request #47: [MPIR-431] Dependency file details section: segregate Java version
belingueres commented on PR #47: URL: https://github.com/apache/maven-project-info-reports-plugin/pull/47#issuecomment-1553778944 I will fix and simplify the javaVersionFormat variable. It does not print versions "1.0" and "1.1". https://github.com/apache/maven-project-info-reports-plugin/blob/9209a7a175041ba1b2e6902f6f2dbb247a96529d/src/main/java/org/apache/maven/report/projectinfo/dependencies/renderer/DependenciesRenderer.java#L94 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-project-info-reports-plugin] belingueres commented on pull request #47: [MPIR-431] Dependency file details section: segregate Java version
belingueres commented on PR #47: URL: https://github.com/apache/maven-project-info-reports-plugin/pull/47#issuecomment-1548861112 I don't get what value should span which columns. IIUC your drawing, the "Test java version" is gone. The max jdk version remains the same. The test max jdk version go into the "Java version" column (changing test scope as the first row of the table). The only value left is the non test scoped jdk version, which should be in the "Java version" column too (rowspan="4" to cover all non test scopes if present). Obviously this is not what you have in mind, so please elaborate. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-project-info-reports-plugin] belingueres commented on pull request #47: [MPIR-431] Dependency file details section: segregate Java version
belingueres commented on PR #47: URL: https://github.com/apache/maven-project-info-reports-plugin/pull/47#issuecomment-1547011760 I'm OK with the first two bullets. Third one I don't understand what do you mean by colspan. Do you mean to center vertically the result to cover compile,runtime and provided rows? like HTML table "rowspan" attribute? I'm OK if it shows clearly and there is no confusion regarding if it is a total covering the 3 non-test scopes, or it is just one of them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-project-info-reports-plugin] belingueres commented on pull request #47: [MPIR-431] Dependency file details section: segregate Java version
belingueres commented on PR #47: URL: https://github.com/apache/maven-project-info-reports-plugin/pull/47#issuecomment-1545008672 Yes this is the kind of conclusions I'd like to derive about the jdk versions by looking at the report, and just separating test scoped deps into its own column I agree it is too simplistic, but I think it offers more value than having only one column for all scopes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
