[GitHub] [maven-release] michael-o commented on pull request #86: MRELEASE-1072 reuse original tag for next development version in case
michael-o commented on pull request #86: URL: https://github.com/apache/maven-release/pull/86#issuecomment-1003737750 True, since we have those counterparts in code, would it make sense to have your new tests to match in amount, shape and naming? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-release] michael-o commented on pull request #86: MRELEASE-1072 reuse original tag for next development version in case
michael-o commented on pull request #86: URL: https://github.com/apache/maven-release/pull/86#issuecomment-1003736930 Since this fix isn't really Subversion-specific, because it affects all SCMs, can you add a Git-based test too? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-release] michael-o commented on pull request #86: MRELEASE-1072 reuse original tag for next development version in case
michael-o commented on pull request #86: URL: https://github.com/apache/maven-release/pull/86#issuecomment-1003605736 This causes failures with master: ``` [ERROR] RewritePomsForDevelopmentPhaseTest.testRewriteBasicPomWithGitFromTag:292->AbstractReleaseTestCase.comparePomFiles:248->AbstractReleaseTestCase.comparePomFiles:254->AbstractReleaseTestCase.comparePomFiles:271->AbstractReleaseTestCase.comparePomFiles:287->AbstractReleaseTestCase.comparePomFiles:350 Check the transformed POM D:\Entwicklung\Projekte\maven-release\maven-release-manager\target\test-classes\projects\rewrite-for-development\basic-pom-with-git-from-tag\pom.xml Expected text value 'original-label' but was 'release-label' - comparing original-label at /project[1]/scm[1]/tag[1]/text()[1] to release-label at /project[1]/scm[1]/tag[1]/text()[1] [ERROR] RewritePomsForDevelopmentPhaseTest.testRewriteBasicPomWithGit:271->AbstractReleaseTestCase.comparePomFiles:248->AbstractReleaseTestCase.comparePomFiles:254->AbstractReleaseTestCase.comparePomFiles:271->AbstractReleaseTestCase.comparePomFiles:287->AbstractReleaseTestCase.comparePomFiles:350 Check the transformed POM D:\Entwicklung\Projekte\maven-release\maven-release-manager\target\test-classes\projects\rewrite-for-development\basic-pom-with-git\pom.xml Expected text value 'HEAD' but was 'release-label' - comparing HEAD at /project[1]/scm[1]/tag[1]/text()[1] to release-label at /project[1]/scm[1]/tag[1]/text()[1] ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-release] michael-o commented on pull request #86: MRELEASE-1072 reuse original tag for next development version in case
michael-o commented on pull request #86: URL: https://github.com/apache/maven-release/pull/86#issuecomment-1003580600 Will look into this as soon as my other open PRs are merged. @kwin Please ping me by ned of next week. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
