[GitHub] [maven-release] rfscholte commented on pull request #56: [MRELEASE-1042] releaseProfiles get overriden by activeProfiles

2021-04-02 Thread GitBox


rfscholte commented on pull request #56:
URL: https://github.com/apache/maven-release/pull/56#issuecomment-812486023


   Merged with 
https://github.com/apache/maven-release/commit/a553e1921a3633848e8a886a0286bf45047b9ab5
   Thanks for the PR


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [maven-release] rfscholte commented on pull request #56: [MRELEASE-1042] releaseProfiles get overriden by activeProfiles

2020-05-22 Thread GitBox


rfscholte commented on pull request #56:
URL: https://github.com/apache/maven-release/pull/56#issuecomment-632628280


   I don't mind if this piece of code is rewritten. For 3.0.0 I extracted a new 
interface `ReleaseDescriptor`, which is part of the API with only (immutable) 
getters. All new classes introduced were written to keep the original behavior, 
but with clear separation of reading and writing. `DefaultReleaseManager` 
contains code to get the final Release final descriptor based on 
goal-configuration and release.properties. It looks like that code deserves 
extra classes in the `org.apache.maven.shared.release.config` package.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org