[GitHub] [maven-resolver] Tibor17 commented on a change in pull request #38: [MRESOLVER-92] Revert MRESOLVER-7
Tibor17 commented on a change in pull request #38: [MRESOLVER-92] Revert
MRESOLVER-7
URL: https://github.com/apache/maven-resolver/pull/38#discussion_r314063690
##
File path:
maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/collect/DefaultDependencyCollector.java
##
@@ -86,12 +79,13 @@
implements DependencyCollector, Service
{
-static final String CONFIG_PROP_MAX_EXCEPTIONS =
"aether.dependencyCollector.maxExceptions";
+private static final String CONFIG_PROP_MAX_EXCEPTIONS =
"aether.dependencyCollector.maxExceptions";
+
+private static final int CONFIG_PROP_MAX_EXCEPTIONS_DEFAULT = 50;
Review comment:
It's from checkstyle failure. When I was building the project the
`maven-checkstyle-plugin` wanted me to declare a constant for unknown number
and string.
No idea how this project could be built without it till now.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-resolver] Tibor17 commented on a change in pull request #38: [MRESOLVER-92] Revert MRESOLVER-7
Tibor17 commented on a change in pull request #38: [MRESOLVER-92] Revert
MRESOLVER-7
URL: https://github.com/apache/maven-resolver/pull/38#discussion_r314063803
##
File path:
maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/collect/DefaultDependencyCollector.java
##
@@ -86,12 +79,13 @@
implements DependencyCollector, Service
{
-static final String CONFIG_PROP_MAX_EXCEPTIONS =
"aether.dependencyCollector.maxExceptions";
+private static final String CONFIG_PROP_MAX_EXCEPTIONS =
"aether.dependencyCollector.maxExceptions";
+
+private static final int CONFIG_PROP_MAX_EXCEPTIONS_DEFAULT = 50;
-static final String CONFIG_PROP_MAX_CYCLES =
"aether.dependencyCollector.maxCycles";
+private static final String CONFIG_PROP_MAX_CYCLES =
"aether.dependencyCollector.maxCycles";
-private static final String CONFIG_PROP_THREADS =
"aether.artifactDescriptor.threads";
-private static final int DEFAULT_THREADS = 5;
+private static final int CONFIG_PROP_MAX_CYCLES_DEFAULT = 10;
Review comment:
The same as before.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-resolver] Tibor17 commented on a change in pull request #38: [MRESOLVER-92] Revert MRESOLVER-7
Tibor17 commented on a change in pull request #38: [MRESOLVER-92] Revert
MRESOLVER-7
URL: https://github.com/apache/maven-resolver/pull/38#discussion_r314063690
##
File path:
maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/collect/DefaultDependencyCollector.java
##
@@ -86,12 +79,13 @@
implements DependencyCollector, Service
{
-static final String CONFIG_PROP_MAX_EXCEPTIONS =
"aether.dependencyCollector.maxExceptions";
+private static final String CONFIG_PROP_MAX_EXCEPTIONS =
"aether.dependencyCollector.maxExceptions";
+
+private static final int CONFIG_PROP_MAX_EXCEPTIONS_DEFAULT = 50;
Review comment:
It's from checkstyle failure. When I was building the project the
`maven-checkstyle-plugin` was wanted be to declare a constant for unknown
number and string.
No idea how this project could be built without it till now.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
