[GitHub] [maven-resolver] michael-o commented on pull request #154: [MRESOLVER-241] Resolver checksum calculation should be driven by layout
michael-o commented on pull request #154: URL: https://github.com/apache/maven-resolver/pull/154#issuecomment-1067683173 Going through now... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-resolver] michael-o commented on pull request #154: [MRESOLVER-241] Resolver checksum calculation should be driven by layout
michael-o commented on pull request #154: URL: https://github.com/apache/maven-resolver/pull/154#issuecomment-1066921491 > IMO, as we still test with `endsWith`, dotless and dotted is important, but for simplicity sake, we'd maybe enforce configuration to use only dotted (dot prefixed) input. OTOH, I'd not apply anything like auto-adding dots, as that may hinder our later efforts to do something else (as we see that having or not having dot as prefix does matters, but we still don't know exactly what and how to use that, so better not allow users to be lazy that may hit us back later). > > Simply put: change factory to enforce leading dots, and update doco that list must have extensions with leading dots. > > Rationale: > > * artifact.getExtension returns dotless extension (so not starting with dot), but sub-artifacts may have dots within extension (jar.asc) > > * enforcing that users use dot-prefixed strings means we are applying this ONLY to sub-artifacts, that again, makes sense. I don't think we want to have top level artifacts that does NOT have checksums. > > * still, having users adding dots, instead code auto-adding it leaves open a possibility for us, to change this later (and maybe use a list of some ant patterns or whatnot, but currently I'd see this as overkill) I follow your reasoning... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-resolver] michael-o commented on pull request #154: [MRESOLVER-241] Resolver checksum calculation should be driven by layout
michael-o commented on pull request #154: URL: https://github.com/apache/maven-resolver/pull/154#issuecomment-1066450554 > What happended to `foo`,`.asc` dot and dotless? Only this one is left. I will put this into testing meanwhile. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-resolver] michael-o commented on pull request #154: [MRESOLVER-241] Resolver checksum calculation should be driven by layout
michael-o commented on pull request #154: URL: https://github.com/apache/maven-resolver/pull/154#issuecomment-1065978388 > If you're referring to Sigstore integration, it's up for discussion what the best naming conventions will be. I have x509, SSH, and PGP signing working. So probably want to keep `.asc` as not to interfere with existing PGP sigs, but for x509 maybe `.sig` and for SSH `.sshsig`. Not sure yet really. OK, let's move this to a separate discussion when we have somthing usable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-resolver] michael-o commented on pull request #154: [MRESOLVER-241] Resolver checksum calculation should be driven by layout
michael-o commented on pull request #154: URL: https://github.com/apache/maven-resolver/pull/154#issuecomment-1065977636 @jvanzyl Should we add `.sig` right away to the default list? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
