[GitHub] [maven-scm] michael-o commented on a change in pull request #103: [SCM-940] remove getModule method
michael-o commented on a change in pull request #103: URL: https://github.com/apache/maven-scm/pull/103#discussion_r427527591 ## File path: maven-scm-test/src/main/java/org/apache/maven/scm/ScmTestCase.java ## @@ -369,7 +362,7 @@ public void assertCommandLine( String expectedCommand, File expectedWorkingDirec /** * @param cmd the executable to run, not null. - * @return true + * @return true iff the command is on the path Review comment: Surprisingly, I have seen this today as IFF. Why not use this one to avoid typo resemblance. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-scm] michael-o commented on a change in pull request #103: [SCM-940] remove getModule method
michael-o commented on a change in pull request #103: URL: https://github.com/apache/maven-scm/pull/103#discussion_r426810897 ## File path: maven-scm-test/src/main/java/org/apache/maven/scm/ScmTestCase.java ## @@ -369,7 +362,7 @@ public void assertCommandLine( String expectedCommand, File expectedWorkingDirec /** * @param cmd the executable to run, not null. - * @return true + * @return true iff the command is on the path Review comment: Don't expect people to know that This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-scm] michael-o commented on a change in pull request #103: [SCM-940] remove getModule method
michael-o commented on a change in pull request #103: URL: https://github.com/apache/maven-scm/pull/103#discussion_r426722832 ## File path: maven-scm-test/src/main/java/org/apache/maven/scm/ScmTestCase.java ## @@ -369,7 +362,7 @@ public void assertCommandLine( String expectedCommand, File expectedWorkingDirec /** * @param cmd the executable to run, not null. - * @return true + * @return true iff the command is on the path Review comment: Typo This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
