[GitHub] [maven-shade-plugin] jenrryyou commented on pull request #73: [MSHADE-378] Shade plugin changes the compression level of nested jar…

2020-11-21 Thread GitBox 


jenrryyou commented on pull request #73:
URL: https://github.com/apache/maven-shade-plugin/pull/73#issuecomment-731699320


   Hi @rmannibucau ,
   Since I have no write access for this repo，I was wondering if you could 
merge this PR or somebody else would do?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-shade-plugin] jenrryyou commented on pull request #73: [MSHADE-378] Shade plugin changes the compression level of nested jar…

2020-11-17 Thread GitBox 


jenrryyou commented on pull request #73:
URL: https://github.com/apache/maven-shade-plugin/pull/73#issuecomment-729328053


   [MSHADE-378] Shade plugin changes the compression level of nested jar 
entries, see more at this [jira ticket 
link](https://issues.apache.org/jira/projects/MSHADE/issues/MSHADE-378?filter=allopenissues)



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-shade-plugin] jenrryyou commented on pull request #73: [MSHADE-378] Shade plugin changes the compression level of nested jar…

2020-11-17 Thread GitBox 


jenrryyou commented on pull request #73:
URL: https://github.com/apache/maven-shade-plugin/pull/73#issuecomment-728792839


   Hi @rmannibucau ,
   A test is added for this PR to verify that shade plugin wouldn't change the 
compression level of nested jar.  By the way,  ZipHeaderPeekInputStream is 
refined and  based on PushbackInputStream now.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-shade-plugin] jenrryyou commented on pull request #73: [MSHADE-378] Shade plugin changes the compression level of nested jar…

2020-10-09 Thread GitBox 


jenrryyou commented on pull request #73:
URL: https://github.com/apache/maven-shade-plugin/pull/73#issuecomment-705325012


   Hi @rmannibucau ,
   thanks for your review and comment，I will add a test for this case. As for 
using PushbackInputStream, it seems like a better 
   idea and I will try it also.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-shade-plugin] jenrryyou commented on pull request #73: [MSHADE-378] Shade plugin changes the compression level of nested jar…

2020-10-07 Thread GitBox 


jenrryyou commented on pull request #73:
URL: https://github.com/apache/maven-shade-plugin/pull/73#issuecomment-705325012


   Hi @rmannibucau ,
   thanks for your review and comment，I will add a test for this case. As for 
using PushbackInputStream, it seems like a better 
   idea and I will try it also.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org