[GitHub] [maven-site-plugin] elharo commented on a diff in pull request #155: [MSITE-833] Remove dependency to maven-compat

2023-06-17 Thread via GitHub 


elharo commented on code in PR #155:
URL: https://github.com/apache/maven-site-plugin/pull/155#discussion_r1232855063


##
src/test/java/org/apache/maven/plugins/site/deploy/SiteDeployMojoTest.java:
##
@@ -30,14 +30,14 @@
  */
 @RunWith(JUnit4.class)
 public class SiteDeployMojoTest extends AbstractMojoTestCase {
-private WagonManager wagonManager;
+private Wagon wagon;
 
 // private Repository repository;
 
 @Before
 public void setUp() throws Exception {
 super.setUp();
-wagonManager = getContainer().lookup(WagonManager.class);
+// wagon = getContainer().lookup( Wagon.class, "scp" );
 // repository = new Repository( "my-repository", 
"scp://repository-host/var/maven2" );

Review Comment:
   I respectfully disagree. I would rather see nine wrong things and one right 
thing than ten wrong things.   It is not a good idea to be consistent with 
existing bad practice, and you do not have to fix all bad code practices to fix 
one thing.
   
   This applies to everything, and in this specific case, commented out code 
should not be left in the repo.
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-site-plugin] elharo commented on a diff in pull request #155: [MSITE-833] Remove dependency to maven-compat

2023-06-16 Thread via GitHub 


elharo commented on code in PR #155:
URL: https://github.com/apache/maven-site-plugin/pull/155#discussion_r1232855063


##
src/test/java/org/apache/maven/plugins/site/deploy/SiteDeployMojoTest.java:
##
@@ -30,14 +30,14 @@
  */
 @RunWith(JUnit4.class)
 public class SiteDeployMojoTest extends AbstractMojoTestCase {
-private WagonManager wagonManager;
+private Wagon wagon;
 
 // private Repository repository;
 
 @Before
 public void setUp() throws Exception {
 super.setUp();
-wagonManager = getContainer().lookup(WagonManager.class);
+// wagon = getContainer().lookup( Wagon.class, "scp" );
 // repository = new Repository( "my-repository", 
"scp://repository-host/var/maven2" );

Review Comment:
   I respectfully disagree. I would rather see none wrong things and one right 
thing than ten wrong things.   It is not a good idea to be consistent with 
existing bad practice, and you do not have to fix all bad code practices to fix 
one thing.
   
   This applies to everything, and in this specific case, commented out code 
should not be left in the repo.
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org