[GitHub] [maven-site-plugin] michael-o commented on a diff in pull request #155: [MSITE-833] Remove dependency to maven-compat

2023-06-17 Thread via GitHub 


michael-o commented on code in PR #155:
URL: https://github.com/apache/maven-site-plugin/pull/155#discussion_r1233017160


##
src/test/java/org/apache/maven/plugins/site/deploy/SiteDeployMojoTest.java:
##
@@ -30,14 +30,14 @@
  */
 @RunWith(JUnit4.class)
 public class SiteDeployMojoTest extends AbstractMojoTestCase {
-private WagonManager wagonManager;
+private Wagon wagon;
 
 // private Repository repository;
 
 @Before
 public void setUp() throws Exception {
 super.setUp();
-wagonManager = getContainer().lookup(WagonManager.class);
+// wagon = getContainer().lookup( Wagon.class, "scp" );
 // repository = new Repository( "my-repository", 
"scp://repository-host/var/maven2" );

Review Comment:
   @elharo, please create a followup PR if you want something removed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-site-plugin] michael-o commented on a diff in pull request #155: [MSITE-833] Remove dependency to maven-compat

2023-06-16 Thread via GitHub 


michael-o commented on code in PR #155:
URL: https://github.com/apache/maven-site-plugin/pull/155#discussion_r1232658358


##
src/test/java/org/apache/maven/plugins/site/deploy/SiteDeployMojoTest.java:
##
@@ -30,14 +30,14 @@
  */
 @RunWith(JUnit4.class)
 public class SiteDeployMojoTest extends AbstractMojoTestCase {
-private WagonManager wagonManager;
+private Wagon wagon;
 
 // private Repository repository;
 
 @Before
 public void setUp() throws Exception {
 super.setUp();
-wagonManager = getContainer().lookup(WagonManager.class);
+// wagon = getContainer().lookup( Wagon.class, "scp" );
 // repository = new Repository( "my-repository", 
"scp://repository-host/var/maven2" );

Review Comment:
   This would mean that I'd need to remove all code in comments. For 
consistency reasons, I'd leave it as-is.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org