[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #480: Test only with 2 last Maven core 3.6.x and 3.8.x, avoid deep scanning to find jacoco files

2022-03-04 Thread GitBox 


Tibor17 commented on a change in pull request #480:
URL: https://github.com/apache/maven-surefire/pull/480#discussion_r819424925



##
File path: Jenkinsfile
##
@@ -174,7 +174,7 @@ def buildProcess(String stageKey, String jdkName, String 
mvnName, goals, options
 try {
 if (makeReports) {
 jacoco(changeBuildStatus: false,
-execPattern: '**/*.exec',
+execPattern: '**/target/jacoco*.exec',

Review comment:
   @olamy 
   Performance? Open the online logs as me and you will see that the 
performance is the last problem.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #480: Test only with 2 last Maven core 3.6.x and 3.8.x, avoid deep scanning to find jacoco files

2022-03-01 Thread GitBox 


Tibor17 commented on a change in pull request #480:
URL: https://github.com/apache/maven-surefire/pull/480#discussion_r817111492



##
File path: Jenkinsfile
##
@@ -174,7 +174,7 @@ def buildProcess(String stageKey, String jdkName, String 
mvnName, goals, options
 try {
 if (makeReports) {
 jacoco(changeBuildStatus: false,
-execPattern: '**/*.exec',
+execPattern: '**/target/jacoco*.exec',

Review comment:
   Why you change this line?
   It does not make any difference!
   Do we have any other tools which produce `exec` files? No, we don't!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #480: Test only with 2 last Maven core 3.6.x and 3.8.x, avoid deep scanning to find jacoco files

2022-03-01 Thread GitBox 


Tibor17 commented on a change in pull request #480:
URL: https://github.com/apache/maven-surefire/pull/480#discussion_r817109165



##
File path: Jenkinsfile
##
@@ -30,7 +30,7 @@ properties(
 ]
 )
 final def oses = ['linux':'ubuntu && maven', 'windows':'windows-he']
-final def mavens = env.BRANCH_NAME == 'master' ? ['3.6.x', '3.2.x'] : ['3.2.x']
+final def mavens = env.BRANCH_NAME == 'master' ? ['3.6.x', '3.8.x'] : ['3.8.x']

Review comment:
   This change is not acceptable. We want to and we will accept the range 
Maven 3.2+.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org