[GitHub] [maven-surefire] Tibor17 commented on pull request #344: SUREFIRE-1854 Support include/exclude junit test engine
Tibor17 commented on pull request #344: URL: https://github.com/apache/maven-surefire/pull/344#issuecomment-815849901 @adam11grafik See the master branch. Yes it will be in M6. Thx -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on pull request #344: SUREFIRE-1854 Support include/exclude junit test engine
Tibor17 commented on pull request #344: URL: https://github.com/apache/maven-surefire/pull/344#issuecomment-815826275 I added few unit tests and ushed. Thx for contributing! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on pull request #344: SUREFIRE-1854 Support include/exclude junit test engine
Tibor17 commented on pull request #344: URL: https://github.com/apache/maven-surefire/pull/344#issuecomment-814378922 ok, this looks very well. Pls squash it and I will finish it. Thx for your work! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on pull request #344: SUREFIRE-1854 Support include/exclude junit test engine
Tibor17 commented on pull request #344: URL: https://github.com/apache/maven-surefire/pull/344#issuecomment-814238087 Additionally write an example with POM in the documentation file `junit-platform.apt.vm`. Our users are reading it and they want to see a new features there. Thx -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on pull request #344: SUREFIRE-1854 Support include/exclude junit test engine
Tibor17 commented on pull request #344: URL: https://github.com/apache/maven-surefire/pull/344#issuecomment-812472479 The build is succesful now. Pls squash all commits in one, I would like to see it as one commit and make the last review. Thx -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on pull request #344: SUREFIRE-1854 Support include/exclude junit test engine
Tibor17 commented on pull request #344: URL: https://github.com/apache/maven-surefire/pull/344#issuecomment-812087636 If the assertion statement fails, we would see a complete array in the log, the index of element and types which do not match. So it will be very verbose report. That's the most important difference against assertEquals or assertTrue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on pull request #344: SUREFIRE-1854 Support include/exclude junit test engine
Tibor17 commented on pull request #344: URL: https://github.com/apache/maven-surefire/pull/344#issuecomment-812086654 This would work `assertThat( provider.getFilters() ).asList().element( 0 ).isInstanceOf( TestEngine.class )` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on pull request #344: SUREFIRE-1854 Support include/exclude junit test engine
Tibor17 commented on pull request #344: URL: https://github.com/apache/maven-surefire/pull/344#issuecomment-812034002 Now this looks much better. Pls fix the line length. Are you going to use the `isInstanceOf` in several tests? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on pull request #344: SUREFIRE-1854 Support include/exclude junit test engine
Tibor17 commented on pull request #344: URL: https://github.com/apache/maven-surefire/pull/344#issuecomment-811738125 My advice for you is to copy the class and revert it. Then apply only code changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on pull request #344: SUREFIRE-1854 Support include/exclude junit test engine
Tibor17 commented on pull request #344: URL: https://github.com/apache/maven-surefire/pull/344#issuecomment-811729884 Do you use IntelliJ IDEA? You can configure it so that the IDE will be according to the checkstyle plugin, see this: https://maven.apache.org/developers/conventions/code.html ``` Download maven-idea-codestyle.xml and import it into IDEA using File > Settings > Editor > Code Style > Gear icon > Import Scheme > IntelliJ IDEA Code Style XML ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on pull request #344: SUREFIRE-1854 Support include/exclude junit test engine
Tibor17 commented on pull request #344: URL: https://github.com/apache/maven-surefire/pull/344#issuecomment-811727484 I can see that zou closed your PR but I have reopened it. Please continue here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on pull request #344: SUREFIRE-1854 Support include/exclude junit test engine
Tibor17 commented on pull request #344: URL: https://github.com/apache/maven-surefire/pull/344#issuecomment-811555475 yes, you have modified the biggest class AbstractSurefireMojo. The problem is that I am not able to recognize real changes and the code format. I guess you pressed CRTL+L in your IDE and reformatted the code. Pls do not do that. That;s the reason why the build is not successful. You should place only chages without reformating all the code around. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
