[GitHub] [maven-surefire] Tibor17 commented on pull request #440: [SUREFIRE-1964] Support for method filtering on excludesFile and includesFile
Tibor17 commented on pull request #440: URL: https://github.com/apache/maven-surefire/pull/440#issuecomment-1060959811 @imonteroperez Thank You for your reply, I am very glad. I want to cut two release versions 3.0.0-M5 and 2.22.3, including your feature request to make the users happy. There was 6 days between two messages https://github.com/apache/maven-surefire/pull/460#issuecomment-1047736732 and https://github.com/apache/maven-surefire/pull/460#issuecomment-1053984089 and with the like :+1: so it was a signal for me that we can shift the changes to the target module immediately. @imonteroperez Thank you for contributing. Glad to see you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on pull request #440: [SUREFIRE-1964] Support for method filtering on excludesFile and includesFile
Tibor17 commented on pull request #440: URL: https://github.com/apache/maven-surefire/pull/440#issuecomment-1060861350 @olamy I can repeat myself. The implementation of tests that @imonteroperez was made in a wrong module. Many contributors have made the unit tests in right module and @olamy as a speaker of @imonteroperez requires opposite which was never seen before and this attitude postpones the release. I made everything with Slawomir and we need to understand @olamy that we need to reach the consensus. Thx @olamy for your understanding!!! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on pull request #440: [SUREFIRE-1964] Support for method filtering on excludesFile and includesFile
Tibor17 commented on pull request #440: URL: https://github.com/apache/maven-surefire/pull/440#issuecomment-1059269071 @olamy I don't have time to fight with someone about words. I told the guys that it should be shifted to the right module but you won't understand it and you are basically a speaker of your colleague @imonteroperez . You both were informed. Everybody is happy if I take the comit and simplify his time, so pls appreciate it! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on pull request #440: [SUREFIRE-1964] Support for method filtering on excludesFile and includesFile
Tibor17 commented on pull request #440: URL: https://github.com/apache/maven-surefire/pull/440#issuecomment-1058745846 @imonteroperez It's the same. I used both commits https://github.com/apache/maven-surefire/pull/460/commits/499dc8315e379cb2e3373bc40a9f8b23acbd04f0 and https://github.com/apache/maven-surefire/pull/460/commits/1b721a9ee9d35997fe62376257577d92ddbd968a I have only shifted the changes to the right module. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on pull request #440: [SUREFIRE-1964] Support for method filtering on excludesFile and includesFile
Tibor17 commented on pull request #440: URL: https://github.com/apache/maven-surefire/pull/440#issuecomment-1057397696 @slawekjaranowski Would you pls make the review? Thx -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on pull request #440: [SUREFIRE-1964] Support for method filtering on excludesFile and includesFile
Tibor17 commented on pull request #440: URL: https://github.com/apache/maven-surefire/pull/440#issuecomment-1030817012 Hi @imonteroperez As we spoke before, pls try to finish this with adding Javadoc or extending the existing one for the config parameter, and add the unit tests since the ITs execute some scenario. I guess you do not have permissions to commit into this branch, so feel free to fork it to you own branch. I am currently working on the issue [SUREFIRE-1860](https://issues.apache.org/jira/browse/SUREFIRE-1860). Thx -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on pull request #440: [SUREFIRE-1964] Support for method filtering on excludesFile and includesFile
Tibor17 commented on pull request #440: URL: https://github.com/apache/maven-surefire/pull/440#issuecomment-1022705606 @imonteroperez Thx for the unit test. I will use it. We have not covered this code with unit test yet so this would be worth to do it now. I have my IT already in progress, so I will commit the IT as well. T -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on pull request #440: [SUREFIRE-1964] Support for method filtering on excludesFile and includesFile
Tibor17 commented on pull request #440: URL: https://github.com/apache/maven-surefire/pull/440#issuecomment-1016883323 Hi @imonteroperez :-) Yes of course we will use your ITs. I am glad that you have joined us again! We also need to have updates of the documentation (Javadoc) of the config parameters. Do you have it as well in your commits? Can we use it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on pull request #440: [SUREFIRE-1964] Support for method filtering on excludesFile and includesFile
Tibor17 commented on pull request #440: URL: https://github.com/apache/maven-surefire/pull/440#issuecomment-1011669630 The docs and IT does not exist in here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on pull request #440: [SUREFIRE-1964] Support for method filtering on excludesFile and includesFile
Tibor17 commented on pull request #440: URL: https://github.com/apache/maven-surefire/pull/440#issuecomment-1011650210 @imonteroperez @slawekjaranowski Let's see this as well. The ASM class used `getTest()` for the tests filter. We want to extend it with inc/excludedFiles param but it is not exactly the same list of patterns used by directory/dependency scanner. Additionally, the tests filter should not have the default inc/exc patterns because they should be only in the directory/dependency filters. This way the behavior would be backwards compatible and your feature would present new. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
