[GitHub] [maven-surefire] delanym commented on a diff in pull request #505: [SUREFIRE-2055] Always show random seed

[GitBox]

delanym commented on code in PR #505:
URL: https://github.com/apache/maven-surefire/pull/505#discussion_r846615081


##
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java:
##
@@ -3114,9 +3114,8 @@ protected void warnIfIllegalFailOnFlakeCount() throws 
MojoFailureException
 
 private void printDefaultSeedIfNecessary()
 {
-if ( getRunOrderRandomSeed() == null && getRunOrder().equals( 
RunOrder.RANDOM.name() ) )
+if ( getRunOrder().equals( RunOrder.RANDOM.name() ) )
 {
-setRunOrderRandomSeed( System.nanoTime() );

Review Comment:
   Done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-surefire] delanym commented on a diff in pull request #505: [SUREFIRE-2055] Always show random seed

[GitBox]

delanym commented on code in PR #505:
URL: https://github.com/apache/maven-surefire/pull/505#discussion_r846487634


##
surefire-its/src/test/java/org/apache/maven/surefire/its/RunOrderIT.java:
##
@@ -97,7 +97,17 @@ public void testRandomJUnit4SameSeed()
 }
 }
 }
-
+
+@Test
+public void testRandomJUnit4PrintSeed()
+{
+long seed = 0L;
+OutputValidator validator = executeWithRandomOrder( "junit4", seed );
+validator.verifyTextInLog( "To reproduce ordering use flag" );
+validator = executeWithRandomOrder( "junit4" );
+validator.verifyTextInLog( "To reproduce ordering use flag" );

Review Comment:
   Have I done that right?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org