[GitHub] [maven-surefire] dfa1 commented on issue #227: defaulting trimStackTrace to false
dfa1 commented on issue #227: defaulting trimStackTrace to false URL: https://github.com/apache/maven-surefire/pull/227#issuecomment-483817748 @Tibor17 created PR https://github.com/apache/maven-surefire/pull/230 for branch release/3.0.0-M6 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven-surefire] dfa1 commented on issue #227: defaulting trimStackTrace to false
dfa1 commented on issue #227: defaulting trimStackTrace to false URL: https://github.com/apache/maven-surefire/pull/227#issuecomment-483760206 @Tibor17 it looks like I don't have permissions to push directly: ``` dfa@aman:~/projects/maven-surefire [git:release/3.0.0-M6] $ git log -1 --oneline 8a6b3345 (HEAD -> release/3.0.0-M6) [SUREFIRE-1432] Add extension interface with two implementations for trimStackTrace dfa@aman:~/projects/maven-surefire [git:release/3.0.0-M6] $ git push -v Pushing to https://github.com/apache/maven-surefire remote: Permission to apache/maven-surefire.git denied to dfa1. fatal: unable to access 'https://github.com/apache/maven-surefire/': The requested URL returned error: 403 ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven-surefire] dfa1 commented on issue #227: defaulting trimStackTrace to false
dfa1 commented on issue #227: defaulting trimStackTrace to false URL: https://github.com/apache/maven-surefire/pull/227#issuecomment-481667770 @Tibor17 hello again, sorry for late reply but I was in a family trip. Do I need to push to release branches without creating a PR? I need some guidance here. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven-surefire] dfa1 commented on issue #227: defaulting trimStackTrace to false
dfa1 commented on issue #227: defaulting trimStackTrace to false URL: https://github.com/apache/maven-surefire/pull/227#issuecomment-479580519 @Tibor17 thank you. Just fixed the commit message. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven-surefire] dfa1 commented on issue #227: defaulting trimStackTrace to false
dfa1 commented on issue #227: defaulting trimStackTrace to false URL: https://github.com/apache/maven-surefire/pull/227#issuecomment-479546505 @Tibor17 failing test has been fixed by restoring trimStackTrace=true in af36895fc0bd92af7d5538e1945f57ce7800bce7 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven-surefire] dfa1 commented on issue #227: defaulting trimStackTrace to false
dfa1 commented on issue #227: defaulting trimStackTrace to false URL: https://github.com/apache/maven-surefire/pull/227#issuecomment-479438946 Ok it is definitely related to this change: all tests are green for the parent commit 9b8c30c5ccb5f6c0bb35456c50fdca35abe212da. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven-surefire] dfa1 commented on issue #227: defaulting trimStackTrace to false
dfa1 commented on issue #227: defaulting trimStackTrace to false URL: https://github.com/apache/maven-surefire/pull/227#issuecomment-479424369 @Tibor17 I've got one test failure in "Maven Surefire integration tests", but I'm not sure if this is related to this change: ```[ERROR] Failures: [ERROR] Surefire818NpeIgnoresTestsIT.testBuildFailingWhenErrors:36 wrong number of tests expected:<2> but was:<0> [INFO] [ERROR] Tests run: 792, Failures: 1, Errors: 0, Skipped: 143 ``` For reference: https://issues.apache.org/jira/browse/SUREFIRE-818 Environment: ```$ mvn -v Apache Maven 3.6.0 (97c98ec64a1fdfee7767ce5ffb20918da4f719f3; 2018-10-24T20:41:47+02:00) Maven home: /usr/local/Cellar/maven/3.6.0/libexec Java version: 11.0.2, vendor: Oracle Corporation, runtime: /Library/Java/JavaVirtualMachines/openjdk-11.0.2.jdk/Contents/Home Default locale: en_US, platform encoding: UTF-8 OS name: "mac os x", version: "10.14.3", arch: "x86_64", family: "mac" ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven-surefire] dfa1 commented on issue #227: defaulting trimStackTrace to false
dfa1 commented on issue #227: defaulting trimStackTrace to false URL: https://github.com/apache/maven-surefire/pull/227#issuecomment-479398446 @Tibor17 thank you for guidance: actually my plan was to let travis run tests, let me check locally if I can fix them. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven-surefire] dfa1 commented on issue #227: defaulting trimStackTrace to false
dfa1 commented on issue #227: defaulting trimStackTrace to false URL: https://github.com/apache/maven-surefire/pull/227#issuecomment-479363110 There is a ticket describing this change, along some other discussion: https://issues.apache.org/jira/browse/SUREFIRE-1457 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
