[GitHub] Tibor17 commented on issue #188: [SUREFIRE-1532] MIME type for javascript is now officially application/javascript
Tibor17 commented on issue #188: [SUREFIRE-1532] MIME type for javascript is now officially application/javascript URL: https://github.com/apache/maven-surefire/pull/188#issuecomment-433193204 @based2 This feature with `application/javascript` was released in version 2.22.1. Do you know that? Close this ticket. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Tibor17 commented on issue #188: [SUREFIRE-1532] MIME type for javascript is now officially application/javascript
Tibor17 commented on issue #188: [SUREFIRE-1532] MIME type for javascript is now officially application/javascript URL: https://github.com/apache/maven-surefire/pull/188#issuecomment-421825588 @based2 Did you also run the build (mvn -P run-its install) and did you see the failing test `Surefire260TestWithIdenticalNamesIT`? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Tibor17 commented on issue #188: [SUREFIRE-1532] MIME type for javascript is now officially application/javascript
Tibor17 commented on issue #188: [SUREFIRE-1532] MIME type for javascript is now officially application/javascript URL: https://github.com/apache/maven-surefire/pull/188#issuecomment-402314595 @based2 Please run the build locally. You will see this error `testWithIdenticalNames(org.apache.maven.surefire.its.jiras.Surefire260TestWithIdenticalNamesIT): ReferenceError: "toggleDisplay" is not defined. (javascript url#184)` I am not sure if this is the only one. Feel free to run the build like this `mvn install -P run-its`. See the README. There are instructions to use JDK8+. Do not worry if it takes one hour to complete. One hint, do not overload the PC with other tasks. The build has performance tests and if the delays are paused by overloaded CPU, other tests fail. Squash all changes in one commit. Thx This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Tibor17 commented on issue #188: [SUREFIRE-1532] MIME type for javascript is now officially application/javascript
Tibor17 commented on issue #188: [SUREFIRE-1532] MIME type for javascript is now officially application/javascript URL: https://github.com/apache/maven-surefire/pull/188#issuecomment-402294513 @based2 Let's wait for the response from CI https://builds.apache.org/job/maven-box/job/maven-surefire/job/1532/ This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
