[GitHub] Tibor17 commented on issue #198: [SUREFIRE-1593] Correcting relativization logic to produce valid URIs on Windows
Tibor17 commented on issue #198: [SUREFIRE-1593] Correcting relativization logic to produce valid URIs on Windows URL: https://github.com/apache/maven-surefire/pull/198#issuecomment-439592262 @jglick Pls close your PR, the fix has been pushed. Thx for your work! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Tibor17 commented on issue #198: [SUREFIRE-1593] Correcting relativization logic to produce valid URIs on Windows
Tibor17 commented on issue #198: [SUREFIRE-1593] Correcting relativization logic to produce valid URIs on Windows URL: https://github.com/apache/maven-surefire/pull/198#issuecomment-437622572 linked with discussion https://github.com/apache/maven-surefire/pull/199 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Tibor17 commented on issue #198: [SUREFIRE-1593] Correcting relativization logic to produce valid URIs on Windows
Tibor17 commented on issue #198: [SUREFIRE-1593] Correcting relativization logic to produce valid URIs on Windows URL: https://github.com/apache/maven-surefire/pull/198#issuecomment-437620227 @cstamas @jglick I could not find in Java specification that element in `Class-Path` should be URI `file:///path/to/jar`. Oracle used examples with relative paths only. In case of absolute paths we use URI. Is this expected? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Tibor17 commented on issue #198: [SUREFIRE-1593] Correcting relativization logic to produce valid URIs on Windows
Tibor17 commented on issue #198: [SUREFIRE-1593] Correcting relativization logic to produce valid URIs on Windows URL: https://github.com/apache/maven-surefire/pull/198#issuecomment-437618365 @jglick Pls update your PR with https://github.com/jglick/maven-surefire/pull/1 there are more unit tests and fixes in codestyle in the test class. Thx This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Tibor17 commented on issue #198: [SUREFIRE-1593] Correcting relativization logic to produce valid URIs on Windows
Tibor17 commented on issue #198: [SUREFIRE-1593] Correcting relativization logic to produce valid URIs on Windows URL: https://github.com/apache/maven-surefire/pull/198#issuecomment-437419749 Currently running the build with our changes... This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Tibor17 commented on issue #198: [SUREFIRE-1593] Correcting relativization logic to produce valid URIs on Windows
Tibor17 commented on issue #198: [SUREFIRE-1593] Correcting relativization logic to produce valid URIs on Windows URL: https://github.com/apache/maven-surefire/pull/198#issuecomment-437408939 @jglick Can you squash the commits together, rebase on the master and create a new Jira ticket? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
