[GitHub] eolivelli commented on issue #48: [MENFORCER-324] - Shouldn't we use System.lineSeparator() instead?
eolivelli commented on issue #48: [MENFORCER-324] - Shouldn't we use System.lineSeparator() instead? URL: https://github.com/apache/maven-enforcer/pull/48#issuecomment-457835240 merged as 7e2a57ba338000c62c22690e070796d7e870179e thank you @jsoref This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] eolivelli commented on issue #48: [MENFORCER-324] - Shouldn't we use System.lineSeparator() instead?
eolivelli commented on issue #48: [MENFORCER-324] - Shouldn't we use System.lineSeparator() instead? URL: https://github.com/apache/maven-enforcer/pull/48#issuecomment-457832530 Last run of CI, then merging https://builds.apache.org/job/maven-box/job/maven-enforcer/job/MENFORCER-324/ This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] eolivelli commented on issue #48: [MENFORCER-324] - Shouldn't we use System.lineSeparator() instead?
eolivelli commented on issue #48: [MENFORCER-324] - Shouldn't we use System.lineSeparator() instead? URL: https://github.com/apache/maven-enforcer/pull/48#issuecomment-450839532 Okay so I will continue with this ticket and eventually merge it to master. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] eolivelli commented on issue #48: [MENFORCER-324] - Shouldn't we use System.lineSeparator() instead?
eolivelli commented on issue #48: [MENFORCER-324] - Shouldn't we use System.lineSeparator() instead? URL: https://github.com/apache/maven-enforcer/pull/48#issuecomment-450837815 @michael-o fine to me, let's merge this one. Thank you for your clarification. I feel it would be useful to raise this point to dev list and clean up other plugins. So that when a committer works on a plugin he has a change to clean up line endings writes to stdout This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] eolivelli commented on issue #48: [MENFORCER-324] - Shouldn't we use System.lineSeparator() instead?
eolivelli commented on issue #48: [MENFORCER-324] - Shouldn't we use System.lineSeparator() instead? URL: https://github.com/apache/maven-enforcer/pull/48#issuecomment-450835806 @michael-o does any user ever reported any problem with the output of this plugin ? I think that somehow on Windows (on Linux I am sure it is already working well) there is something which is making the output nicer. Something that is already translating the new line to the corresponding platform dependant value. I think that that constant is to be used when writing to a file for instance, not to stdout. So if no one ever complained why changing the code ? We could introduce some regression hard to debug. What's your opinion ? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] eolivelli commented on issue #48: [MENFORCER-324] - Shouldn't we use System.lineSeparator() instead?
eolivelli commented on issue #48: [MENFORCER-324] - Shouldn't we use System.lineSeparator() instead? URL: https://github.com/apache/maven-enforcer/pull/48#issuecomment-450826573 Seems to me and to the contributor himself that this change is not needed. Are there any other cases in other plugins ? We should keep consistent behavior among all the plugins. I am -0 on this patch. Feel free to commit but I think we can leave without it. I appreciate the work and patience of @jsoref . Thank you This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] eolivelli commented on issue #48: [MENFORCER-324] - Shouldn't we use System.lineSeparator() instead?
eolivelli commented on issue #48: [MENFORCER-324] - Shouldn't we use System.lineSeparator() instead? URL: https://github.com/apache/maven-enforcer/pull/48#issuecomment-446691000 @jsoref can you please rebase to latest master ? What about changing the title and commit message and the JIRA issue title to something like "Use System.lineSeparator() instead of '\n'" This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] eolivelli commented on issue #48: [MENFORCER-324] - Shouldn't we use System.lineSeparator() instead?
eolivelli commented on issue #48: [MENFORCER-324] - Shouldn't we use System.lineSeparator() instead? URL: https://github.com/apache/maven-enforcer/pull/48#issuecomment-446312211 I think that we don't need this change if noone ever reported errors on Windows and Mac. I appreciate @jsoref work and the fact that he is responding to suggestions and requests of the maintainers of this code base. The initial request was Karl This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] eolivelli commented on issue #48: [MENFORCER-324] - Shouldn't we use System.lineSeparator() instead?
eolivelli commented on issue #48: [MENFORCER-324] - Shouldn't we use System.lineSeparator() instead? URL: https://github.com/apache/maven-enforcer/pull/48#issuecomment-446195872 @jsoref thank you for sending this patch. Before merging this PR I have to understand @khmarbaise and @Tibor17 concerns. Does any Windows user ever reported problems with new lines ? I guess that Java or some other layer translates '\n' to the correct EOL depending on the platform. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
