[GitHub] hboutemy commented on issue #197: [MNG-6533] Test: ProjectBuildingException miss reference to MavenProject
hboutemy commented on issue #197: [MNG-6533] Test: ProjectBuildingException miss reference to MavenProject URL: https://github.com/apache/maven/pull/197#issuecomment-454330830 merged to master thank you for this hard contribution: I hope this won't be the last :) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] hboutemy commented on issue #197: [MNG-6533] Test: ProjectBuildingException miss reference to MavenProject
hboutemy commented on issue #197: [MNG-6533] Test: ProjectBuildingException miss reference to MavenProject URL: https://github.com/apache/maven/pull/197#issuecomment-454005490 @mickaelistria no problem I rebased the branch on current master, fixing the conflict, then added one commit to reduce from Exception to InvalidArtifactRTException please review and tell me what you think about it before we review on the mailing list for merge to master This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] hboutemy commented on issue #197: [MNG-6533] Test: ProjectBuildingException miss reference to MavenProject
hboutemy commented on issue #197: [MNG-6533] Test: ProjectBuildingException miss reference to MavenProject URL: https://github.com/apache/maven/pull/197#issuecomment-450147594 I reworked the PR, creating one initial little refactoring commit that makes the later modification a lot easier to understand IMHO: see MNG-6533-2 branch I must confess that I'm having hard times understanding the main "Prefer passing the interim project in ProjectBuildingResult" commit... One little thing that I feel is not good: catch(Exception) in the last commit. is catching InvalidArtifactRTException not sufficient? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
