[GitHub] khmarbaise commented on issue #45: [MENFORCER-319] Handle UTF-8 BOM when parsing pom.xml files
khmarbaise commented on issue #45: [MENFORCER-319] Handle UTF-8 BOM when parsing pom.xml files URL: https://github.com/apache/maven-enforcer/pull/45#issuecomment-457910280 From my point of view looks fine now. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] khmarbaise commented on issue #45: [MENFORCER-319] Handle UTF-8 BOM when parsing pom.xml files
khmarbaise commented on issue #45: [MENFORCER-319] Handle UTF-8 BOM when parsing pom.xml files URL: https://github.com/apache/maven-enforcer/pull/45#issuecomment-438667508 Please don't change existing tests...please add a new one! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] khmarbaise commented on issue #45: [MENFORCER-319] Handle UTF-8 BOM when parsing pom.xml files
khmarbaise commented on issue #45: [MENFORCER-319] Handle UTF-8 BOM when parsing pom.xml files URL: https://github.com/apache/maven-enforcer/pull/45#issuecomment-438485075 The patch looks good so far but unfortunately I don't see a test case for that.. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
