[GitHub] matthiasbalke commented on a change in pull request #2: added support for excludePattern (fixes MPATCH-20)

2018-11-09 Thread GitBox 
matthiasbalke commented on a change in pull request #2: added support for 
excludePattern (fixes MPATCH-20)
URL: https://github.com/apache/maven-patch-plugin/pull/2#discussion_r232216512
 
 

 ##
 File path: src/it/exclude-multiple-patterns-from-patchDirectory/pom.xml
 ##
 @@ -0,0 +1,66 @@
+
+http://maven.apache.org/POM/4.0.0"; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
+  xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/maven-v4_0_0.xsd";>
+  4.0.0
+  
+  test
+  exclude-multiple-patterns-from-patchDirectory
+  exclude-multiple-patterns-from-patchDirectory
+  1.0-SNAPSHOT
+
+  
+UTF-8
+  
+
+  
+
+  
+org.apache.maven.plugins
+maven-patch-plugin
+@pom.version@
 
 Review comment:
   done


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] matthiasbalke commented on a change in pull request #2: added support for excludePattern (fixes MPATCH-20)

2018-11-09 Thread GitBox 
matthiasbalke commented on a change in pull request #2: added support for 
excludePattern (fixes MPATCH-20)
URL: https://github.com/apache/maven-patch-plugin/pull/2#discussion_r232216460
 
 

 ##
 File path: src/main/java/org/apache/maven/plugin/patch/ApplyMojo.java
 ##
 @@ -237,6 +238,16 @@
 @Parameter( defaultValue = "false" )
 private boolean binary;
 
+/**
+ * List of ANT-style exclude patterns. These patterns are used to exclude 
patch files found
+ * in the {@link ApplyMojo#patchDirectory}. These exclude patterns does 
not apply to a static defined list of
+ * {@link ApplyMojo#patches}.
+ *
+ * @since 1.3
+ */
+@Parameter
+private List excludes;
 
 Review comment:
   Ok thanks for explaining, I changed it.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] matthiasbalke commented on a change in pull request #2: added support for excludePattern (fixes MPATCH-20)

2018-11-09 Thread GitBox 
matthiasbalke commented on a change in pull request #2: added support for 
excludePattern (fixes MPATCH-20)
URL: https://github.com/apache/maven-patch-plugin/pull/2#discussion_r232216532
 
 

 ##
 File path: src/it/cant-exclude-patches-from-patches/pom.xml
 ##
 @@ -0,0 +1,69 @@
+
+http://maven.apache.org/POM/4.0.0"; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
+  xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/maven-v4_0_0.xsd";>
+  4.0.0
+  
+  test
+  cant-exclude-patches-from-patches
+  cant-exclude-patches-from-patches
+  1.0-SNAPSHOT
+
+  
+UTF-8
+  
+
+  
+
+  
+org.apache.maven.plugins
+maven-patch-plugin
+@pom.version@
 
 Review comment:
   done


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] matthiasbalke commented on a change in pull request #2: added support for excludePattern (fixes MPATCH-20)

2018-11-09 Thread GitBox 
matthiasbalke commented on a change in pull request #2: added support for 
excludePattern (fixes MPATCH-20)
URL: https://github.com/apache/maven-patch-plugin/pull/2#discussion_r232216491
 
 

 ##
 File path: src/it/exclude-patches-from-patchDirectory/pom.xml
 ##
 @@ -0,0 +1,65 @@
+
+http://maven.apache.org/POM/4.0.0"; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
+  xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/maven-v4_0_0.xsd";>
+  4.0.0
+  
+  test
+  exclude-patches-from-patchDirectory
+  exclude-patches-from-patchDirectory
+  1.0-SNAPSHOT
+
+  
+UTF-8
+  
+
+  
+
+  
+org.apache.maven.plugins
+maven-patch-plugin
+@pom.version@
 
 Review comment:
   Ok thanks for explaining, I changed it.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] matthiasbalke commented on a change in pull request #2: added support for excludePattern (fixes MPATCH-20)

2018-11-08 Thread GitBox 
matthiasbalke commented on a change in pull request #2: added support for 
excludePattern (fixes MPATCH-20)
URL: https://github.com/apache/maven-patch-plugin/pull/2#discussion_r231797372
 
 

 ##
 File path: src/it/exclude-patches-from-patchDirectory/pom.xml
 ##
 @@ -0,0 +1,65 @@
+
+http://maven.apache.org/POM/4.0.0"; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
+  xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/maven-v4_0_0.xsd";>
+  4.0.0
+  
+  test
+  exclude-patches-from-patchDirectory
+  exclude-patches-from-patchDirectory
+  1.0-SNAPSHOT
+
+  
+UTF-8
+  
+
+  
+
+  
+org.apache.maven.plugins
+maven-patch-plugin
+@pom.version@
 
 Review comment:
   Whats the difference here? Is it a more modern syntax? I used the same as 
the integration tests used before (see remove-emtpy-files/pom.xml).


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] matthiasbalke commented on a change in pull request #2: added support for excludePattern (fixes MPATCH-20)

2018-11-08 Thread GitBox 
matthiasbalke commented on a change in pull request #2: added support for 
excludePattern (fixes MPATCH-20)
URL: https://github.com/apache/maven-patch-plugin/pull/2#discussion_r231796857
 
 

 ##
 File path: src/main/java/org/apache/maven/plugin/patch/ApplyMojo.java
 ##
 @@ -237,6 +238,16 @@
 @Parameter( defaultValue = "false" )
 private boolean binary;
 
+/**
+ * List of ANT-style exclude patterns. These patterns are used to exclude 
patch files found
+ * in the {@link ApplyMojo#patchDirectory}. These exclude patterns does 
not apply to a static defined list of
+ * {@link ApplyMojo#patches}.
+ *
+ * @since 1.3
+ */
+@Parameter
+private List excludes;
 
 Review comment:
   Currently no generics are getting used within the code of the plugin. Thats 
why I kept this style. Do you want to change it anyways?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services