[GitHub] mcimbora commented on a change in pull request #23: [MRESOLVER-63] FileTransformer#transformData(File) should also throw TransformException
mcimbora commented on a change in pull request #23: [MRESOLVER-63] FileTransformer#transformData(File) should also throw TransformException URL: https://github.com/apache/maven-resolver/pull/23#discussion_r233620013 ## File path: maven-resolver-api/src/main/java/org/eclipse/aether/transform/FileTransformationException.java ## @@ -0,0 +1,79 @@ +package org.eclipse.aether.transform; + +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +import java.io.File; + +import org.eclipse.aether.RepositoryException; + +/** + * Thrown when file transformation failed. + */ +public class FileTransformationException +extends RepositoryException Review comment: Good point, thanks for the explaination and prompt review. The exception now inherits directly from Exception. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mcimbora commented on a change in pull request #23: [MRESOLVER-63] FileTransformer#transformData(File) should also throw TransformException
mcimbora commented on a change in pull request #23: [MRESOLVER-63] FileTransformer#transformData(File) should also throw TransformException URL: https://github.com/apache/maven-resolver/pull/23#discussion_r233619531 ## File path: maven-resolver-api/src/main/java/org/eclipse/aether/transform/FileTransformer.java ## @@ -47,5 +46,5 @@ * @param file the file with the original data * @return the transformed data */ -InputStream transformData( File file ) throws IOException; +InputStream transformData( File file ) throws FileTransformationException; Review comment: Included TransformException in the throws clause. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mcimbora commented on a change in pull request #23: [MRESOLVER-63] FileTransformer#transformData(File) should also throw TransformException
mcimbora commented on a change in pull request #23: [MRESOLVER-63]
FileTransformer#transformData(File) should also throw TransformException
URL: https://github.com/apache/maven-resolver/pull/23#discussion_r233619327
##
File path:
maven-resolver-api/src/main/java/org/eclipse/aether/transform/FileTransformationException.java
##
@@ -0,0 +1,79 @@
+package org.eclipse.aether.transform;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.io.File;
+
+import org.eclipse.aether.RepositoryException;
+
+/**
+ * Thrown when file transformation failed.
+ */
+public class FileTransformationException
+extends RepositoryException
+{
+
+private final transient File file;
+
+/**
+ * Creates a new exception with the specified file.
+ *
+ * @param file The file which transformation failed, may be {@code null}.
+ */
+public FileTransformationException( File file )
Review comment:
Removed.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
