[GitHub] michael-o commented on a change in pull request #186: better performant for some Collection operations
michael-o commented on a change in pull request #186: better performant for some Collection operations URL: https://github.com/apache/maven/pull/186#discussion_r226877230 ## File path: maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java ## @@ -1194,7 +1194,7 @@ else if ( userSuppliedConfigurationProcessorCount > 1 ) sb.append( String.format( "%s\n", configurationProcessor.getClass().getName() ) ); } } -sb.append( String.format( "\n" ) ); +sb.append( "\n" ); Review comment: agree This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] michael-o commented on a change in pull request #186: better performant for some Collection operations
michael-o commented on a change in pull request #186: better performant for some Collection operations URL: https://github.com/apache/maven/pull/186#discussion_r226877242 ## File path: maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java ## @@ -1194,7 +1194,7 @@ else if ( userSuppliedConfigurationProcessorCount > 1 ) sb.append( String.format( "%s\n", configurationProcessor.getClass().getName() ) ); } } -sb.append( String.format( "\n" ) ); +sb.append( "\n" ); Review comment: agree This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] michael-o commented on a change in pull request #186: better performant for some Collection operations
michael-o commented on a change in pull request #186: better performant for some Collection operations URL: https://github.com/apache/maven/pull/186#discussion_r226874360 ## File path: maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java ## @@ -1194,7 +1194,7 @@ else if ( userSuppliedConfigurationProcessorCount > 1 ) sb.append( String.format( "%s\n", configurationProcessor.getClass().getName() ) ); } } -sb.append( String.format( "\n" ) ); +sb.append( "\n" ); Review comment: this should be platform specific This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] michael-o commented on a change in pull request #186: better performant for some Collection operations
michael-o commented on a change in pull request #186: better performant for
some Collection operations
URL: https://github.com/apache/maven/pull/186#discussion_r226874313
##
File path:
maven-core/src/test/java/org/apache/maven/lifecycle/internal/stub/MojoExecutorStub.java
##
@@ -50,10 +50,7 @@ public void execute( MavenSession session, MojoExecution
mojoExecution, ProjectI
public void execute( MavenSession session, List
mojoExecutions, ProjectIndex projectIndex )
throws LifecycleExecutionException
{
-for ( MojoExecution mojoExecution : mojoExecutions )
-{
-executions.add( mojoExecution );
-}
+executions.addAll(mojoExecutions);
Review comment:
whitespace missing
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] michael-o commented on a change in pull request #186: better performant for some Collection operations
michael-o commented on a change in pull request #186: better performant for
some Collection operations
URL: https://github.com/apache/maven/pull/186#discussion_r226874313
##
File path:
maven-core/src/test/java/org/apache/maven/lifecycle/internal/stub/MojoExecutorStub.java
##
@@ -50,10 +50,7 @@ public void execute( MavenSession session, MojoExecution
mojoExecution, ProjectI
public void execute( MavenSession session, List
mojoExecutions, ProjectIndex projectIndex )
throws LifecycleExecutionException
{
-for ( MojoExecution mojoExecution : mojoExecutions )
-{
-executions.add( mojoExecution );
-}
+executions.addAll(mojoExecutions);
Review comment:
whiterrace missing
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
