[GitHub] tcollignon commented on issue #5: MASSEMBLY-617 : add ability to set fileMappers in FileSet in maven as…

2019-01-06 Thread GitBox
tcollignon commented on issue #5: MASSEMBLY-617 : add ability to set 
fileMappers in FileSet in maven as…
URL: 
https://github.com/apache/maven-assembly-plugin/pull/5#issuecomment-451772714
 
 
   Note : This PR could close 
https://issues.apache.org/jira/browse/MASSEMBLY-886 too


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] tcollignon commented on issue #5: MASSEMBLY-617 : add ability to set fileMappers in FileSet in maven as…

2019-01-01 Thread GitBox
tcollignon commented on issue #5: MASSEMBLY-617 : add ability to set 
fileMappers in FileSet in maven as…
URL: 
https://github.com/apache/maven-assembly-plugin/pull/5#issuecomment-450758965
 
 
   So @plamentotev I have try to do something.
   Can you tell my what you think please?
   I'm not very comfortable with MDO, I'm sorry.
   I have added a large amount of code in AddDirectoryTask, and I think it's 
not very good with the beautiful il else ..., if you have better please tell me


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] tcollignon commented on issue #5: MASSEMBLY-617 : add ability to set fileMappers in FileSet in maven as…

2018-12-31 Thread GitBox
tcollignon commented on issue #5: MASSEMBLY-617 : add ability to set 
fileMappers in FileSet in maven as…
URL: 
https://github.com/apache/maven-assembly-plugin/pull/5#issuecomment-450660998
 
 
   thx for your answer @plamentotev , I will try to finish this when I can


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] tcollignon commented on issue #5: MASSEMBLY-617 : add ability to set fileMappers in FileSet in maven as…

2018-07-28 Thread GitBox
tcollignon commented on issue #5: MASSEMBLY-617 : add ability to set 
fileMappers in FileSet in maven as…
URL: 
https://github.com/apache/maven-assembly-plugin/pull/5#issuecomment-408590464
 
 
   Hi
   
   This need certainly to add test but I don't know where :(
   
   And in MDO it"s wrong in version and again I don't know what i must do in it
   
   Thx


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services