[GitHub] wilx commented on issue #45: [MENFORCER-319] Handle UTF-8 BOM when parsing pom.xml files
wilx commented on issue #45: [MENFORCER-319] Handle UTF-8 BOM when parsing pom.xml files URL: https://github.com/apache/maven-enforcer/pull/45#issuecomment-441952663 [**@khmarbaise**](https://github.com/khmarbaise) commented on [Nov 14, 2018, 2:48 PM GMT+1](https://github.com/apache/maven-enforcer/pull/45#issuecomment-438667508 "2018-11-14T13:48:38Z - Replied by Github Reply Comments"): > Please don't change existing tests...please add a new one! I have reverted the previous modification and created a new test with UTF-8 BOM encoding. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wilx commented on issue #45: [MENFORCER-319] Handle UTF-8 BOM when parsing pom.xml files
wilx commented on issue #45: [MENFORCER-319] Handle UTF-8 BOM when parsing pom.xml files URL: https://github.com/apache/maven-enforcer/pull/45#issuecomment-438678773 [**@khmarbaise**](https://github.com/khmarbaise) commented on [14 Nov 2018, 14:48 CET](https://github.com/apache/maven-enforcer/pull/45#issuecomment-438667508 "2018-11-14T13:48:38Z - Replied by Github Reply Comments"): > Please don't change existing tests...please add a new one! This does not make any sense in this case, IMHO. I have only added the BOM to the existing test so that it exercises the modification. I cannot think of any other that that would not be exact duplicate of the current `banDuplicatePomDependencyVersions` with the 3 bytes of UTF-8 BOM added. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wilx commented on issue #45: [MENFORCER-319] Handle UTF-8 BOM when parsing pom.xml files
wilx commented on issue #45: [MENFORCER-319] Handle UTF-8 BOM when parsing pom.xml files URL: https://github.com/apache/maven-enforcer/pull/45#issuecomment-438628257 [**@khmarbaise**](https://github.com/khmarbaise) commented on [14 Nov 2018, 00:59 CET](https://github.com/apache/maven-enforcer/pull/45#issuecomment-438485075 "2018-11-13T23:59:34Z - Replied by Github Reply Comments"): > The patch looks good so far but unfortunately I don't see a test case for that.. I have updated pom.xml of integration test of banDuplicatePomDependencyVersions rule to be in UTF-8 BOM encoding. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
