Re: [PR] [MASSEMBLY-1008] Wrong use of dependency scopes [maven-assembly-plugin]

[via GitHub]

cstamas commented on code in PR #166:
URL: 
https://github.com/apache/maven-assembly-plugin/pull/166#discussion_r1394207292


##
pom.xml:
##
@@ -71,8 +71,8 @@ under the License.
   
 8
 2.2.0
-3.2.5
-1.7.5
+3.9.5

Review Comment:
   No ,is irrelevant



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [MASSEMBLY-1008] Wrong use of dependency scopes [maven-assembly-plugin]

[via GitHub]

slawekjaranowski commented on code in PR #166:
URL: 
https://github.com/apache/maven-assembly-plugin/pull/166#discussion_r1394176097


##
pom.xml:
##
@@ -71,8 +71,8 @@ under the License.
   
 8
 2.2.0
-3.2.5
-1.7.5
+3.9.5

Review Comment:
   Do we need such update for this exercises?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[PR] [MASSEMBLY-1008] Wrong use of dependency scopes [maven-assembly-plugin]

[via GitHub]

cstamas opened a new pull request, #166:
URL: https://github.com/apache/maven-assembly-plugin/pull/166

   This IT demonstrates how assembly plugin (among others) does it wrongly, as 
the plugin code probably originates from Maven2 times.
   
   What happens:
   * "single" mojo resolves test project dependencies (see Mojo annotations)
   * then it reads assembly descriptor (so it only learns now what user wants)
   * then uses resolved project dependencies to deliver descriptor contents
   
   But, here is a problem that IT demonstrates: the delivered list of files are 
NOT runtime scoped, they are "test scope filtered for runtime leaves" which is 
not the same thing. By the way, dependency plugin demonstrates same behavior: 
wrongly assumes that "test" graph is super set of "runtime" tree, but that is 
not true nor was never true since Maven3 (resolver), it was true ONLY in Maven2 
times.
   
   The proper runtime graph of IT project as shown by resolver is this:
   ```
   prompt> graph test:massembly-1008:jar:1
   [INFO] Collecting test:massembly-1008:jar:1
   [INFO] 
   [INFO] test:massembly-1008:jar:1
   [INFO] \- com.google.inject:guice:jar:6.0.0 [compile]
   [INFO]+- javax.inject:javax.inject:jar:1 [compile]
   [INFO]+- jakarta.inject:jakarta.inject-api:jar:2.0.1 [compile]
   [INFO]+- aopalliance:aopalliance:jar:1.0 [compile]
   [INFO]\- com.google.guava:guava:jar:31.0.1-jre [compile]
   [INFO]   +- com.google.guava:failureaccess:jar:1.0.1 [compile]
   [INFO]   +- 
com.google.guava:listenablefuture:jar:.0-empty-to-avoid-conflict-with-guava 
[compile]
   [INFO]   +- com.google.code.findbugs:jsr305:jar:3.0.2 [compile]
   [INFO]   +- org.checkerframework:checker-qual:jar:3.12.0 [compile]
   [INFO]   +- com.google.errorprone:error_prone_annotations:jar:2.7.1 
[compile]
   [INFO]   \- com.google.j2objc:j2objc-annotations:jar:1.3 [compile]
   prompt> 
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org