Re: [PR] [MENFORCER-390] "requireFilesExist" no longer handles non-canonical paths [maven-enforcer]

[via GitHub]

roadSurfer commented on PR #297:
URL: https://github.com/apache/maven-enforcer/pull/297#issuecomment-1828211606

   That should be the whitepsace issues sorted. I also generated the site 
locally and it appeared OK to me.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [MENFORCER-390] "requireFilesExist" no longer handles non-canonical paths [maven-enforcer]

[via GitHub]

roadSurfer commented on PR #297:
URL: https://github.com/apache/maven-enforcer/pull/297#issuecomment-1828111369

   No, they are not intended. That will be my IDE doing its own thing, I'll
   use a different editor and update.
   
   On Mon, 27 Nov 2023 at 15:20, Torbjorn-Svensson ***@***.***>
   wrote:
   
   > Are all the white space changes in the .md files intended?
   > As far as I know, some of the trailing white spaces are needed in order to
   > not join the lines.
   >
   > —
   > Reply to this email directly, view it on GitHub
   > 
,
   > or unsubscribe
   > 

   > .
   > You are receiving this because you authored the thread.Message ID:
   > ***@***.***>
   >
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [MENFORCER-390] "requireFilesExist" no longer handles non-canonical paths [maven-enforcer]

[via GitHub]

Torbjorn-Svensson commented on PR #297:
URL: https://github.com/apache/maven-enforcer/pull/297#issuecomment-1828041274

   Are all the white space changes in the .md files intended?
   As far as I know, some of the trailing white spaces are needed in order to 
not join the lines.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [MENFORCER-390] "requireFilesExist" no longer handles non-canonical paths [maven-enforcer]

[via GitHub]

roadSurfer commented on PR #297:
URL: https://github.com/apache/maven-enforcer/pull/297#issuecomment-1827585294

   I have added some words to the affected documentation on case-sensitivity, 
as well as some explic testing of symbolic links.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [MENFORCER-390] "requireFilesExist" no longer handles non-canonical paths [maven-enforcer]

[via GitHub]

slawekjaranowski commented on PR #297:
URL: https://github.com/apache/maven-enforcer/pull/297#issuecomment-1825978578

   Ok, the simple `file.exists()` should be enough in normal usage ... 
   
   I only think - if we don't break and special cases ... but agree more 
complicated check should be done optionally or by next rule
   
   By the way we can mention in documentation a way how file existence is 
checked to be clear.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[PR] [MENFORCER-390] "requireFilesExist" no longer handles non-canonical paths [maven-enforcer]

[via GitHub]

roadSurfer opened a new pull request, #297:
URL: https://github.com/apache/maven-enforcer/pull/297

   This reverts the change from MENFORCER-364 as this led to a regressions with 
symbolic links.
   
   The fundamental issue is that there is no clean way to deal with 
case-sensitivity as OSs can have multuple filesystems mounted that follow 
different rules. Thus the simple `file.exists()` is, despite the limitations, 
probably best. Those requiring more stringent checks writing their own handling.
   
   Following this checklist to help us incorporate your 
   contribution quickly and easily:
   
- [ ] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/MENFORCER) filed 
  for the change (usually before you start working on it).  Trivial 
changes like typos do not 
  require a JIRA issue.  Your pull request should address just this 
issue, without 
  pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line 
and body.
- [ ] Format the pull request title like `[MENFORCER-XXX] - Fixes bug in 
ApproximateQuantiles`,
  where you replace `MENFORCER-XXX` with the appropriate JIRA issue. 
Best practice
  is to use the JIRA issue title in the pull request title and in the 
first line of the 
  commit message.
- [ ] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more 
thorough check will 
  be performed on your pull request automatically.
- [ ] You have run the integration tests successfully (`mvn -Prun-its clean 
verify`).
   
   If your pull request is about ~20 lines of code you don't need to sign an
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
   please ask on the developers list.
   
   To make clear that you license your contribution under 
   the [Apache License Version 2.0, January 
2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
- [ ] I hereby declare this contribution to be licenced under the [Apache 
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   
- [ ] In any other case, please file an [Apache Individual Contributor 
License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org