Re: [PR] [MJARSIGNER-63] Exposing certchain on site sign-goal documentation [maven-jarsigner-plugin]
slachiewicz merged PR #14: URL: https://github.com/apache/maven-jarsigner-plugin/pull/14 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MJARSIGNER-63] Exposing certchain on site sign-goal documentation [maven-jarsigner-plugin]
schedin commented on PR #14: URL: https://github.com/apache/maven-jarsigner-plugin/pull/14#issuecomment-1847147734 Even though `readonly` is not about documentation (primary), I feel that in this context (for this specific case and JIRA tickets) it is about documentation. In my comment in https://issues.apache.org/jira/projects/MJARSIGNER/issues/MJARSIGNER-63 I have provided a (rather long) example that shows that it is possible to set this parameter, even if it is readonly (or undocumented). My opinion is that we (the community) should make a conscious choice to make sure that this parameter is configurable by the end-user (and also documented). I think this was the original intent of https://issues.apache.org/jira/projects/MJARSIGNER/issues/MJARSIGNER-53 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MJARSIGNER-63] Exposing certchain on site sign-goal documentation [maven-jarsigner-plugin]
elharo commented on PR #14: URL: https://github.com/apache/maven-jarsigner-plugin/pull/14#issuecomment-1847124242 It's possible that this should not have readonly=true. I don't have a real opinion on that. But let's make sure we're making conscious choice here and the PR title reflects what we're trying to do. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MJARSIGNER-63] Exposing certchain on site sign-goal documentation [maven-jarsigner-plugin]
elharo commented on PR #14: URL: https://github.com/apache/maven-jarsigner-plugin/pull/14#issuecomment-1847123083 readonly is not about documentation. See https://maven.apache.org/plugin-tools/maven-plugin-annotations/apidocs/org/apache/maven/plugins/annotations/Parameter.html#readonly() -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MJARSIGNER-63] exposing certchain on site sign-goal documentation [maven-jarsigner-plugin]
schedin commented on PR #14: URL: https://github.com/apache/maven-jarsigner-plugin/pull/14#issuecomment-1846763409 I have rebased this pull request on master. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MJARSIGNER-63] exposing certchain on site sign-goal documentation [maven-jarsigner-plugin]
schedin commented on PR #14: URL: https://github.com/apache/maven-jarsigner-plugin/pull/14#issuecomment-1845339374 I looked at https://maven.apache.org/plugin-tools/apidocs/org/apache/maven/plugins/annotations/Parameter.html#readonly() and my interpretation of this annotation parameter is that it exist for a use case it don't fully understand (usage of common POM elements). My guess is that this readonly parameter is not related to Java attribute immutability. I'm also (mostly guessing) that the original author (@olamy ?) copy-pasted from the "wrong" thing. Perhaps from MavenProject/Settings/MavenSession? My assumption is that the intention is that the end-user should be able to configure this parameter in a `` block. While reading the javadoc for readonly it looks like this should be false (or not defined, so it is false per default) for the indented use case of specifiying certchain. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [MJARSIGNER-63] exposing certchain on site sign-goal documentation [maven-jarsigner-plugin]
schedin opened a new pull request, #14: URL: https://github.com/apache/maven-jarsigner-plugin/pull/14 Making certchain not read-only so that the Maven site documentation will make is visible on https://maven.apache.org/plugins/maven-jarsigner-plugin/sign-mojo.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
