Re: [PR] [MNG-7266] Remove maven-compat [maven]
gnodet commented on PR #1487: URL: https://github.com/apache/maven/pull/1487#issuecomment-2205390080 > > > > > > I did investigate again and now I understand what actually happens: When I run current reporting plugins wich do _not_ depend on Maven Compat I still get CNFE, e.g., RepositorySystem or others because in [967d8fc](https://github.com/apache/maven/commit/967d8fc19cbb8a78410ceed70bd91c2e628da813) a bunch of classes were moved to Compat and are now gone. What apparantly was fine with Maven 3.x is now not possible with Maven 4. If all changes in [967d8fc](https://github.com/apache/maven/commit/967d8fc19cbb8a78410ceed70bd91c2e628da813) are correct then those plugins aren't compatible with 4 and need a separate branch for 4. > > > > > > > > > > > > > > > Do you know which class is required and not found ? > > > > > > > > > > > > Oh, sorry `RepositorySystem`. For those plugins, a dependency on maven-compat needs to be added afaik. > > > > > > > > > This means that compat cannot be removed for those plugins? How to proceed in case? > > > > > > All of these plugins are one Maven 3.6.3 already. I prefer the Resolver approach. Second option. > > Agreed, I think m-site-p is ok, it's maven-project-info-reports-plugin which depends on maven-compat and needs to be updated. Actually, adding maven-compat does not work, and switching to `org.apache.maven.bridge.MavenRepositorySystem` does not work too. The reason is the classes are present in maven-core 3.x and maven-compat 4.x. A real switch to maven-resolver api will work better. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MNG-7266] Remove maven-compat [maven]
gnodet commented on PR #1487: URL: https://github.com/apache/maven/pull/1487#issuecomment-2205267196 > > > > > I did investigate again and now I understand what actually happens: When I run current reporting plugins wich do _not_ depend on Maven Compat I still get CNFE, e.g., RepositorySystem or others because in [967d8fc](https://github.com/apache/maven/commit/967d8fc19cbb8a78410ceed70bd91c2e628da813) a bunch of classes were moved to Compat and are now gone. What apparantly was fine with Maven 3.x is now not possible with Maven 4. If all changes in [967d8fc](https://github.com/apache/maven/commit/967d8fc19cbb8a78410ceed70bd91c2e628da813) are correct then those plugins aren't compatible with 4 and need a separate branch for 4. > > > > > > > > > > > > Do you know which class is required and not found ? > > > > > > > > > Oh, sorry `RepositorySystem`. For those plugins, a dependency on maven-compat needs to be added afaik. > > > > > > This means that compat cannot be removed for those plugins? How to proceed in case? > > All of these plugins are one Maven 3.6.3 already. I prefer the Resolver approach. Second option. Agreed, I think m-site-p is ok, it's maven-project-info-reports-plugin which depends on maven-compat and needs to be updated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MNG-7266] Remove maven-compat [maven]
michael-o commented on PR #1487: URL: https://github.com/apache/maven/pull/1487#issuecomment-2205220610 > > > > I did investigate again and now I understand what actually happens: When I run current reporting plugins wich do _not_ depend on Maven Compat I still get CNFE, e.g., RepositorySystem or others because in [967d8fc](https://github.com/apache/maven/commit/967d8fc19cbb8a78410ceed70bd91c2e628da813) a bunch of classes were moved to Compat and are now gone. What apparantly was fine with Maven 3.x is now not possible with Maven 4. If all changes in [967d8fc](https://github.com/apache/maven/commit/967d8fc19cbb8a78410ceed70bd91c2e628da813) are correct then those plugins aren't compatible with 4 and need a separate branch for 4. > > > > > > > > > Do you know which class is required and not found ? > > > > > > Oh, sorry `RepositorySystem`. For those plugins, a dependency on maven-compat needs to be added afaik. > > This means that compat cannot be removed for those plugins? How to proceed in case? All of these plugins are one Maven 3.6.3 already. I prefer the Resolver approach. Second option. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MNG-7266] Remove maven-compat [maven]
gnodet commented on PR #1487: URL: https://github.com/apache/maven/pull/1487#issuecomment-2205195453 > > > > I did investigate again and now I understand what actually happens: When I run current reporting plugins wich do _not_ depend on Maven Compat I still get CNFE, e.g., RepositorySystem or others because in [967d8fc](https://github.com/apache/maven/commit/967d8fc19cbb8a78410ceed70bd91c2e628da813) a bunch of classes were moved to Compat and are now gone. What apparantly was fine with Maven 3.x is now not possible with Maven 4. If all changes in [967d8fc](https://github.com/apache/maven/commit/967d8fc19cbb8a78410ceed70bd91c2e628da813) are correct then those plugins aren't compatible with 4 and need a separate branch for 4. > > > > > > > > > Do you know which class is required and not found ? > > > > > > Oh, sorry `RepositorySystem`. For those plugins, a dependency on maven-compat needs to be added afaik. > > This means that compat cannot be removed for those plugins? How to proceed in case? There are three ways: * add maven-compat dependency to the plugins * migrate the plugins to use resolver and require Maven 3.6.x * migrate the plugin to 4.x API and require Maven 4.x The first one, means that we can't just delete the code now, but we can stop providing it by default in the Maven distribution. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MNG-7266] Remove maven-compat [maven]
gnodet commented on PR #1487: URL: https://github.com/apache/maven/pull/1487#issuecomment-2203324239 > > > > > > > These two: > > > > > > > > > > > > > > * maven-plugin-tools/maven-plugin-plugin > > > > > > > * maven-project-info-reports-plugin > > > > > > > > > > > > > > > > > > maven-plugin-tools/maven-plugin-plugin does NOT depend on maven-compat, does it? Also, it contains traces of archaic (Maven2 times) when pom was considered "metadata" and plugin had to maintain maven-metadata.xml as well (something not needed since Resolver 1.9.x, as all data deployed generally are "artifacts", no more "metadata" to be handled by client code needed). Unsure what to be done here, maybe just bite the bullet, and raise the m-p-p prerequisite to 3.9.x (this would raise _build time_ Maven requirement for all built plugins, but not runtime requirements) and drop all this cruft. > > > > > > Am looking into the other one. > > > > > > EDIT: the other one still uses MAT so convert it to resolver? ... and shared dep tree that is also to be dropped/deprecated. so a LOT of deprecated stuff... > > > > > > > > > > > > > > > We could also switch them directly to the Maven 4 API... > > > > > > > > > > > > I'd prefer to solve this for 3.x as well to make easier for us. > > > > > > > > > We won't be able to get rid of maven-compat in Maven 3.x branch. > > > > > > Also fwiw, m-plugin-p does not depend on maven-compat or MAT anymore (and still supports Maven 3 plugins for now). > > But that is on m-plugin-tools on master, no? The 3.x branch will remain as-is in this regard? No, 3.x is free of those too afaik ``` [INFO] -< org.apache.maven.plugins:maven-plugin-plugin >- [INFO] Building Maven Plugin Plugin 3.13.2-SNAPSHOT [INFO] from pom.xml [INFO] -[ maven-plugin ]- [INFO] [INFO] --- dependency:3.6.1:tree (default-cli) @ maven-plugin-plugin --- [INFO] org.apache.maven.plugins:maven-plugin-plugin:maven-plugin:3.13.2-SNAPSHOT [INFO] +- org.apache.maven:maven-core:jar:3.9.6:provided [INFO] | +- org.apache.maven:maven-settings-builder:jar:3.9.6:provided [INFO] | | \- org.codehaus.plexus:plexus-sec-dispatcher:jar:2.0:provided [INFO] | | \- org.codehaus.plexus:plexus-cipher:jar:2.0:provided [INFO] | +- org.apache.maven:maven-builder-support:jar:3.9.6:provided [INFO] | +- org.apache.maven:maven-model-builder:jar:3.9.6:provided [INFO] | +- org.apache.maven:maven-resolver-provider:jar:3.9.6:provided [INFO] | +- org.apache.maven.resolver:maven-resolver-impl:jar:1.9.18:provided [INFO] | | \- org.apache.maven.resolver:maven-resolver-named-locks:jar:1.9.18:provided [INFO] | +- org.apache.maven.resolver:maven-resolver-spi:jar:1.9.18:provided [INFO] | +- org.apache.maven.shared:maven-shared-utils:jar:3.3.4:provided [INFO] | +- org.eclipse.sisu:org.eclipse.sisu.inject:jar:0.9.0.M2:provided [INFO] | +- com.google.inject:guice:jar:5.1.0:provided [INFO] | | \- aopalliance:aopalliance:jar:1.0:provided [INFO] | +- com.google.guava:guava:jar:32.0.1-jre:provided [INFO] | +- com.google.guava:failureaccess:jar:1.0.1:provided [INFO] | +- javax.inject:javax.inject:jar:1:runtime [INFO] | +- org.codehaus.plexus:plexus-classworlds:jar:2.7.0:compile [INFO] | +- org.codehaus.plexus:plexus-interpolation:jar:1.26:provided [INFO] | +- org.codehaus.plexus:plexus-component-annotations:jar:2.1.0:provided [INFO] | +- org.apache.commons:commons-lang3:jar:3.12.0:runtime [INFO] | \- org.slf4j:slf4j-api:jar:1.7.36:compile [INFO] +- org.apache.maven.plugin-tools:maven-plugin-tools-api:jar:3.13.2-SNAPSHOT:compile [INFO] | +- org.apache.maven.reporting:maven-reporting-api:jar:3.1.1:compile [INFO] | | \- org.apache.maven.doxia:doxia-sink-api:jar:1.11.1:compile [INFO] | | \- org.apache.maven.doxia:doxia-logging-api:jar:1.11.1:compile [INFO] | +- org.codehaus.plexus:plexus-xml:jar:3.0.1:compile [INFO] | +- org.apache.httpcomponents:httpclient:jar:4.5.14:compile [INFO] | | +- commons-logging:commons-logging:jar:1.2:compile [INFO] | | \- commons-codec:commons-codec:jar:1.11:compile [INFO] | +- org.apache.httpcomponents:httpcore:jar:4.4.16:compile [INFO] | +- org.apache.maven.wagon:wagon-provider-api:jar:3.5.3:compile [INFO] | \- org.codehaus.plexus:plexus-java:jar:1.2.0:compile [INFO] +- org.apache.maven.plugin-tools:maven-plugin-tools-generators:jar:3.13.2-SNAPSHOT:compile [INFO] | +- org.apache.velocity:velocity:jar:1.7:compile [INFO] | | \- commons-lang:commons-lang:jar:2.4:compile [INFO] | +- org.jsoup:jsoup:jar:1.17.2:compile [INFO] | \- net.sf.jtidy:jtidy:jar:r938:compile [INFO] +- org.apache.maven.plu
Re: [PR] [MNG-7266] Remove maven-compat [maven]
michael-o commented on PR #1487: URL: https://github.com/apache/maven/pull/1487#issuecomment-2203132098 > > > > > > These two: > > > > > > > > > > > > * maven-plugin-tools/maven-plugin-plugin > > > > > > * maven-project-info-reports-plugin > > > > > > > > > > > > > > > maven-plugin-tools/maven-plugin-plugin does NOT depend on maven-compat, does it? Also, it contains traces of archaic (Maven2 times) when pom was considered "metadata" and plugin had to maintain maven-metadata.xml as well (something not needed since Resolver 1.9.x, as all data deployed generally are "artifacts", no more "metadata" to be handled by client code needed). Unsure what to be done here, maybe just bite the bullet, and raise the m-p-p prerequisite to 3.9.x (this would raise _build time_ Maven requirement for all built plugins, but not runtime requirements) and drop all this cruft. > > > > > Am looking into the other one. > > > > > EDIT: the other one still uses MAT so convert it to resolver? ... and shared dep tree that is also to be dropped/deprecated. so a LOT of deprecated stuff... > > > > > > > > > > > > We could also switch them directly to the Maven 4 API... > > > > > > > > > I'd prefer to solve this for 3.x as well to make easier for us. > > > > > > We won't be able to get rid of maven-compat in Maven 3.x branch. > > Also fwiw, m-plugin-p does not depend on maven-compat or MAT anymore (and still supports Maven 3 plugins for now). But that is on m-plugin-tools on master, no? The 3.x branch will remain as-is in this regard? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MNG-7266] Remove maven-compat [maven]
michael-o commented on PR #1487: URL: https://github.com/apache/maven/pull/1487#issuecomment-2203130039 > > > > > These two: > > > > > > > > > > * maven-plugin-tools/maven-plugin-plugin > > > > > * maven-project-info-reports-plugin > > > > > > > > > > > > maven-plugin-tools/maven-plugin-plugin does NOT depend on maven-compat, does it? Also, it contains traces of archaic (Maven2 times) when pom was considered "metadata" and plugin had to maintain maven-metadata.xml as well (something not needed since Resolver 1.9.x, as all data deployed generally are "artifacts", no more "metadata" to be handled by client code needed). Unsure what to be done here, maybe just bite the bullet, and raise the m-p-p prerequisite to 3.9.x (this would raise _build time_ Maven requirement for all built plugins, but not runtime requirements) and drop all this cruft. > > > > Am looking into the other one. > > > > EDIT: the other one still uses MAT so convert it to resolver? ... and shared dep tree that is also to be dropped/deprecated. so a LOT of deprecated stuff... > > > > > > > > > We could also switch them directly to the Maven 4 API... > > > > > > I'd prefer to solve this for 3.x as well to make easier for us. > > We won't be able to get rid of maven-compat in Maven 3.x branch. Deleting no, but we cannot also replace the code to Resolver with 3.6.3 baseline? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MNG-7266] Remove maven-compat [maven]
michael-o commented on PR #1487: URL: https://github.com/apache/maven/pull/1487#issuecomment-2168164269 Yet another finding: ``` $ for proj in maven-doxia* maven-reporting-* maven-site-plugin; do grep -r -F -f maven-compat-classes --include='*/src/main/java/**.java' $proj ; done | grep -v org.apache.maven.reporting.MavenReportException maven-site-plugin/src/main/java/org/apache/maven/plugins/site/descriptor/SiteDescriptorArtifactMetadata.java:import org.apache.maven.artifact.metadata.AbstractArtifactMetadata; maven-site-plugin/src/main/java/org/apache/maven/plugins/site/descriptor/SiteDescriptorArtifactMetadata.java:import org.apache.maven.artifact.repository.metadata.RepositoryMetadataStoreException; ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MNG-7266] Remove maven-compat [maven]
michael-o commented on PR #1487: URL: https://github.com/apache/maven/pull/1487#issuecomment-2168030966 @Giovds please rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MNG-7266] Remove maven-compat [maven]
michael-o commented on PR #1487: URL: https://github.com/apache/maven/pull/1487#issuecomment-2154676402 Preparing Maven 3.6.3 releases are ongoing. As soon as they are finished I will rebase my work on top of these and check all UTs and ITs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MNG-7266] Remove maven-compat [maven]
cstamas commented on PR #1487: URL: https://github.com/apache/maven/pull/1487#issuecomment-2133427438 Cruft piled up in Maven should not be underestimated :smile: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MNG-7266] Remove maven-compat [maven]
michael-o commented on PR #1487: URL: https://github.com/apache/maven/pull/1487#issuecomment-2132856197 > > > @cstamas @michael-o one blocker after upgrading to latest site is [AbstractProjectInfoReport.java](https://github.com/apache/maven-project-info-reports-plugin/blob/master/src/main/java/org/apache/maven/report/projectinfo/AbstractProjectInfoReport.java) which uses the `org.apache.maven.repository.RepositorySystem` class from `maven-compat`. That part also uses MAT... > > > > > > This is something I need to look at as a whole (reporting plugins) with @cstamas when the current Maven Reporting votes are done and Maven Site Plugin is done as well. I am currently working on lifting the reporting plugin to 3.6.3 first, whenever possible. So please bear with me. > > Sure, np. I just had a quick look again at this PR with the latest site plugin, so just wanted to report the outcome. Thanks, I did have this on my radar. I assumed that the cleanup in Maven Reporting Impl was enough. It obviously wasn't. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MNG-7266] Remove maven-compat [maven]
gnodet commented on PR #1487: URL: https://github.com/apache/maven/pull/1487#issuecomment-2132819017 > > @cstamas @michael-o one blocker after upgrading to latest site is [AbstractProjectInfoReport.java](https://github.com/apache/maven-project-info-reports-plugin/blob/master/src/main/java/org/apache/maven/report/projectinfo/AbstractProjectInfoReport.java) which uses the `org.apache.maven.repository.RepositorySystem` class from `maven-compat`. That part also uses MAT... > > This is something I need to look at as a whole (reporting plugins) with @cstamas when the current Maven Reporting votes are done and Maven Site Plugin is done as well. I am currently working on lifting the reporting plugin to 3.6.3 first, whenever possible. So please bear with me. Sure, np. I just had a quick look again with at this PR with the latest site plugin, so just wanted to report the outcome. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MNG-7266] Remove maven-compat [maven]
michael-o commented on PR #1487: URL: https://github.com/apache/maven/pull/1487#issuecomment-2132779147 > @cstamas @michael-o one blocker after upgrading to latest site is [AbstractProjectInfoReport.java](https://github.com/apache/maven-project-info-reports-plugin/blob/master/src/main/java/org/apache/maven/report/projectinfo/AbstractProjectInfoReport.java) which uses the `org.apache.maven.repository.RepositorySystem` class from `maven-compat`. That part also uses MAT... This is something I need to look at as a whole (reporting plugins) with @cstamas when the current Maven Reporting votes are done and Maven Site Plugin is done as well. I am currently working on lifting the reporting plugin to 3.6.3 first, whenever possible. So please bear with me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MNG-7266] Remove maven-compat [maven]
gnodet commented on PR #1487: URL: https://github.com/apache/maven/pull/1487#issuecomment-2132769075 @cstamas @michael-o one blocker after upgrading to latest site is https://github.com/apache/maven-project-info-reports-plugin/blob/master/src/main/java/org/apache/maven/report/projectinfo/AbstractProjectInfoReport.java which uses the `org.apache.maven.repository.RepositorySystem` class from `maven-compat`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MNG-7266] Remove maven-compat [maven]
cstamas commented on PR #1487: URL: https://github.com/apache/maven/pull/1487#issuecomment-2082768935 Fix for m-p-p on the way https://github.com/apache/maven-plugin-tools/pull/280 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MNG-7266] Remove maven-compat [maven]
michael-o commented on PR #1487: URL: https://github.com/apache/maven/pull/1487#issuecomment-2082487297 > > Someone needs to fix maven-plugin-plugin first: > > Does this still stands? Or latest one works? Both are unrelated. Maven Plugin Plugin remains broken without Maven Compat. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MNG-7266] Remove maven-compat [maven]
cstamas commented on PR #1487: URL: https://github.com/apache/maven/pull/1487#issuecomment-2082445871 > Someone needs to fix maven-plugin-plugin first: > Does this still stands? Or latest one works? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MNG-7266] Remove maven-compat [maven]
michael-o commented on PR #1487: URL: https://github.com/apache/maven/pull/1487#issuecomment-2081432308 As far as I can see with ``` commit 7c8334ac2466b05ca0cdbeb265dc4b85b0099a2a Author: Michael Osipov Date: 2023-03-18T23:00:40+01:00 [DOXIASITETOOLS-294] Replace legacy artifact resolution with Maven Resolver ``` So Doxia 2.0.0 should be fine with this, but ultimate test will be when this release train is done and I can test more. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MNG-7266] Remove maven-compat [maven]
michael-o commented on PR #1487: URL: https://github.com/apache/maven/pull/1487#issuecomment-2081428694 Someone needs to fix maven-plugin-plugin first: ``` [INFO] [INFO] --- jar:3.3.0:jar (default-jar) @ maven-site-plugin --- [INFO] Building jar: /var/osipovmi/Projekte/maven-site-plugin/target/maven-site-plugin-4.0.0-M14-SNAPSHOT.jar [INFO] [INFO] --- plugin:3.10.2:addPluginArtifactMetadata (default-addPluginArtifactMetadata) @ maven-site-plugin --- [INFO] -- [INFO] BUILD FAILURE [INFO] -- [INFO] Total time: 02:07 min [INFO] Finished at: 2024-04-28T12:34:23+02:00 [INFO] -- [ERROR] Failed to execute goal org.apache.maven.plugins:maven-plugin-plugin:3.10.2:addPluginArtifactMetadata (default-addPluginArtifactMetadata) on project maven-site-plugin: Execution default-addPluginArtifactMetadata of goal org.apache.maven.plugins:maven-plugin-plugin:3.10.2:addPluginArtifactMetadata failed: A required class was missing while executing org.apache.maven.plugins:maven-plugin-plugin:3.10.2:addPluginArtifactMetadata: org/apache/maven/artifact/repository/metadata/ArtifactRepositoryMetadata [ERROR] - [ERROR] realm =plugin>org.apache.maven.plugins:maven-plugin-plugin:3.10.2 [ERROR] strategy = org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy [ERROR] urls[0] = file:/net/home/osipovmi/.m2/repository/org/apache/maven/plugins/maven-plugin-plugin/3.10.2/maven-plugin-plugin-3.10.2.jar [ERROR] urls[1] = file:/net/home/osipovmi/.m2/repository/org/apache/maven/plugin-tools/maven-plugin-tools-api/3.10.2/maven-plugin-tools-api-3.10.2.jar ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MNG-7266] Remove maven-compat [maven]
cstamas commented on PR #1487: URL: https://github.com/apache/maven/pull/1487#issuecomment-2080430009 For start, maven-compat is really just test dep, not needed at runtime https://github.com/apache/maven-doxia-sitetools/pull/151 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MNG-7266] Remove maven-compat [maven]
michael-o commented on PR #1487: URL: https://github.com/apache/maven/pull/1487#issuecomment-2079743348 > @michael-o if you look at failed CI jobs, they are due msite plugin wanting stuff that is actually removed (maven-compat). Am interested could you -- maybe even within this PR -- set up M versions that hopefully does not depends on maven-compat? Ok, I see what you are after. Will look into this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MNG-7266] Remove maven-compat [maven]
cstamas commented on PR #1487: URL: https://github.com/apache/maven/pull/1487#issuecomment-2079652561 @michael-o if you look at failed CI jobs, they are due msite plugin wanting stuff that is actually removed (maven-compat). Am interested could you -- maybe even within this PR -- set up M versions that hopefully does not depends on maven-compat? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MNG-7266] Remove maven-compat [maven]
michael-o commented on PR #1487: URL: https://github.com/apache/maven/pull/1487#issuecomment-2079429030 > @michael-o can we have a taste on new Ms from site suite? You want to me run the entire test setup of Doxia/MSITE w/o depending on maven-compat or with with PR of Maven 4? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MNG-7266] Remove maven-compat [maven]
Giovds commented on PR #1487: URL: https://github.com/apache/maven/pull/1487#issuecomment-2079380222 I've noticed in the .svg that the `compat` module sits between `core` and `wagon-provider-api`. What is the next step for the `wagon-provider-api`? Does this mean we remove the `wagon-provider-api` as well, or do we link `core` with `wagon-provider-api`, or is there another path we should take? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MNG-7266] Remove maven-compat [maven]
cstamas commented on PR #1487: URL: https://github.com/apache/maven/pull/1487#issuecomment-2079366763 @michael-o can we have a taste on new Ms from site suite? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MNG-7266] Remove maven-compat [maven]
cstamas commented on PR #1487: URL: https://github.com/apache/maven/pull/1487#issuecomment-2079366084 maven-site plugin is still maven2 dependant... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [MNG-7266] Remove maven-compat [maven]
Giovds opened a new pull request, #1487: URL: https://github.com/apache/maven/pull/1487 Following this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [x] Each commit in the pull request should have a meaningful subject line and body. - [x] Format the pull request title like `[MNG-XXX] SUMMARY`, where you replace `MNG-XXX` and `SUMMARY` with the appropriate JIRA issue. - [x] Also format the first line of the commit message like `[MNG-XXX] SUMMARY`. Best practice is to use the JIRA issue title in both the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] You have run the [Core IT][core-its] successfully. If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [x] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). [core-its]: https://maven.apache.org/core-its/core-it-suite/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
