Re: [PR] [MNG-7891] Abstract ExtensionConfigurationModule from CliRequest [maven]

2023-10-17 Thread via GitHub 


gnodet merged PR #1272:
URL: https://github.com/apache/maven/pull/1272


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [MNG-7891] Abstract ExtensionConfigurationModule from CliRequest [maven]

2023-10-02 Thread via GitHub 


laeubi commented on code in PR #1272:
URL: https://github.com/apache/maven/pull/1272#discussion_r1342688431


##
maven-embedder/src/main/java/org/apache/maven/cli/ExtensionConfigurationModule.java:
##
@@ -27,18 +27,18 @@
 import org.apache.maven.internal.xml.XmlPlexusConfiguration;
 import org.apache.maven.model.v4.MavenTransformer;
 import org.codehaus.plexus.configuration.PlexusConfiguration;
+import org.codehaus.plexus.interpolation.AbstractValueSource;
 import org.codehaus.plexus.interpolation.InterpolationException;
-import org.codehaus.plexus.interpolation.PropertiesBasedValueSource;
 import org.codehaus.plexus.interpolation.StringSearchInterpolator;
 
 class ExtensionConfigurationModule implements Module {

Review Comment:
   Could this be a public class I think m2e will want to reuse that class at 
some point in time



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [MNG-7891] Abstract ExtensionConfigurationModule from CliRequest [maven]

2023-10-02 Thread via GitHub 


laeubi commented on code in PR #1272:
URL: https://github.com/apache/maven/pull/1272#discussion_r1342685628


##
maven-embedder/src/main/java/org/apache/maven/cli/ExtensionConfigurationModule.java:
##
@@ -27,18 +27,18 @@
 import org.apache.maven.internal.xml.XmlPlexusConfiguration;
 import org.apache.maven.model.v4.MavenTransformer;
 import org.codehaus.plexus.configuration.PlexusConfiguration;
+import org.codehaus.plexus.interpolation.AbstractValueSource;
 import org.codehaus.plexus.interpolation.InterpolationException;
-import org.codehaus.plexus.interpolation.PropertiesBasedValueSource;
 import org.codehaus.plexus.interpolation.StringSearchInterpolator;
 
 class ExtensionConfigurationModule implements Module {
 
 private final CoreExtensionEntry extension;
-private final CliRequest cliRequest;
+private final AbstractValueSource valueSource;
 
-ExtensionConfigurationModule(CoreExtensionEntry extension, CliRequest 
cliRequest) {
+ExtensionConfigurationModule(CoreExtensionEntry extension, 
AbstractValueSource valueSource) {

Review Comment:
   ```suggestion
   ExtensionConfigurationModule(CoreExtensionEntry extension, ValueSource 
... valueSources) {
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [MNG-7891] Abstract ExtensionConfigurationModule from CliRequest [maven]

2023-10-02 Thread via GitHub 


laeubi commented on code in PR #1272:
URL: https://github.com/apache/maven/pull/1272#discussion_r1342685628


##
maven-embedder/src/main/java/org/apache/maven/cli/ExtensionConfigurationModule.java:
##
@@ -27,18 +27,18 @@
 import org.apache.maven.internal.xml.XmlPlexusConfiguration;
 import org.apache.maven.model.v4.MavenTransformer;
 import org.codehaus.plexus.configuration.PlexusConfiguration;
+import org.codehaus.plexus.interpolation.AbstractValueSource;
 import org.codehaus.plexus.interpolation.InterpolationException;
-import org.codehaus.plexus.interpolation.PropertiesBasedValueSource;
 import org.codehaus.plexus.interpolation.StringSearchInterpolator;
 
 class ExtensionConfigurationModule implements Module {
 
 private final CoreExtensionEntry extension;
-private final CliRequest cliRequest;
+private final AbstractValueSource valueSource;
 
-ExtensionConfigurationModule(CoreExtensionEntry extension, CliRequest 
cliRequest) {
+ExtensionConfigurationModule(CoreExtensionEntry extension, 
AbstractValueSource valueSource) {

Review Comment:
   ```suggestion
   ExtensionConfigurationModule(CoreExtensionEntry extension, 
AbstractValueSource ... valueSources) {
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[PR] [MNG-7891] Abstract ExtensionConfigurationModule from CliRequest [maven]

2023-10-02 Thread via GitHub 


gnodet opened a new pull request, #1272:
URL: https://github.com/apache/maven/pull/1272

   Follow-up to MNG-7891 to make Maven Daemon integration easier.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org