Re: [PR] [MNG-7982] Switch to enable transitivity in depMgr used by Maven [maven]
cstamas merged PR #1357: URL: https://github.com/apache/maven/pull/1357 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MNG-7982] Switch to enable transitivity in depMgr used by Maven [maven]
cstamas commented on PR #1357: URL: https://github.com/apache/maven/pull/1357#issuecomment-1887094814 > I mean you build the project with maven 4, upload to central, and a maven 3 projects depends on it. Yes, in that case they may be differences. BUT, since we talk about _two distinct projects_: your, that is built with mvn4, and theirs (consumer) built with mvn3. So they will anyway have more dependencies, not just your lib, and they will anyway have to handle their transitive hull, hence _maybe_ will need to have more entries in their depMgt to make things work out for them. Just like things worked so far, no change here. In general, I don't see this as an issue at all, here is why: consumer either suffered from issue like https://issues.apache.org/jira/browse/MNG-7003 and they had it fixed, or they do not suffer from this issue. I see this just like making maven "more correct", "more convergent", am pretty much sure we do not _break anything_ with this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MNG-7982] Switch to enable transitivity in depMgr used by Maven [maven]
gnodet commented on PR #1357: URL: https://github.com/apache/maven/pull/1357#issuecomment-1887066792 > > However, I have no idea what the impact is if one builds a project with the _transitive_ dependency manager, but uses it with the _classic_ one in Maven 3. Could that break the consumer side ? > > I don't quite understand: so _same project_ that is once built with Maven 4 and once with Maven 3? Or an artifact that is dependency once in Maven4 built project and once in Maven3 project? Or WDYM? I mean you build the project with maven 4, upload to central, and a maven 3 projects depends on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MNG-7982] Switch to enable transitivity in depMgr used by Maven [maven]
cstamas commented on PR #1357: URL: https://github.com/apache/maven/pull/1357#issuecomment-1886835845 Yes, we have separate issue for that https://github.com/apache/maven/pull/1373 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MNG-7982] Switch to enable transitivity in depMgr used by Maven [maven]
gnodet commented on code in PR #1357: URL: https://github.com/apache/maven/pull/1357#discussion_r1448599723 ## pom.xml: ## @@ -176,7 +176,7 @@ under the License. 1.26 1.0.0 4.0.1 -2.0.0-alpha-5 +2.0.0-alpha-6 Review Comment: This should be in a separate commit / PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MNG-7982] Switch to enable transitivity in depMgr used by Maven [maven]
cstamas commented on PR #1357: URL: https://github.com/apache/maven/pull/1357#issuecomment-1880869332 > However, I have no idea what the impact is if one builds a project with the _transitive_ dependency manager, but uses it with the _classic_ one in Maven 3. Could that break the consumer side ? I don't quite understand: so _same project_ that is once built with Maven 4 and once with Maven 3? Or an artifact that is dependency once in Maven4 built project and once in Maven3 project? Or WDYM? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MNG-7982] Switch to enable transitivity in depMgr used by Maven [maven]
gnodet commented on PR #1357: URL: https://github.com/apache/maven/pull/1357#issuecomment-1865512751 > Hmm, still thinking a bit out loud but at some point it was discussed that the consumed pom would be "cleaned for central" (flatten maven plugin like etc) to ensure the consumers see it as the producer in terms of resolution, whatever version it uses, is it still in the scope? If so depMgt is maybe no more a thing transitively and then we just do what we want for maven 4, wdyt? Keeping deployed artifacts consumable by maven 3 is still the plan to day, and yes, this kinda imply we can't really bring-in things that would require a change at consumption time in maven 3. However, in Maven 4, the 4.1.0 model has a flag `preserveModelVersion` which can be used to force the usage of 4.1.0 model at deployment time. This could be used to force the trigger of the new behaviour on the consumer side, at the cost of requiring maven 4.0.0. However, I have no idea what the impact is if one builds a project with the _transitive_ dependency manager, but uses it with the _classic_ one in Maven 3. Could that break the consumer side ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MNG-7982] Switch to enable transitivity in depMgr used by Maven [maven]
rmannibucau commented on PR #1357: URL: https://github.com/apache/maven/pull/1357#issuecomment-1864990604 Hmm, still thinking a bit out loud but at some point it was discussed that the consumed pom would be "cleaned for central" (flatten maven plugin like etc) to ensure the consumers see it as the producer in terms of resolution, whatever version it uses, is it still in the scope? If so depMgt is maybe no more a thing transitively and then we just do what we want for maven 4, wdyt? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org