Re: [PR] [MNG-7999] Cleanup [maven]

[via GitHub]

cstamas commented on code in PR #1367:
URL: https://github.com/apache/maven/pull/1367#discussion_r1446520933


##
maven-core/src/main/java/org/apache/maven/lifecycle/internal/DependencyContext.java:
##
@@ -48,7 +43,7 @@ public class DependencyContext {
 
 private final Collection scopesToResolveForAggregatedProjects;
 
-private volatile Collection lastDependencyArtifacts = UNRESOLVED;
+private volatile Collection lastDependencyArtifacts = new ArrayList<>();

Review Comment:
   fixed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [MNG-7999] Cleanup [maven]

[via GitHub]

gnodet commented on code in PR #1367:
URL: https://github.com/apache/maven/pull/1367#discussion_r1446515465


##
maven-core/src/main/java/org/apache/maven/lifecycle/internal/DependencyContext.java:
##
@@ -48,7 +43,7 @@ public class DependencyContext {
 
 private final Collection scopesToResolveForAggregatedProjects;
 
-private volatile Collection lastDependencyArtifacts = UNRESOLVED;
+private volatile Collection lastDependencyArtifacts = new ArrayList<>();

Review Comment:
   `Collections.emptyList()`, as this collection is never written to.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[PR] [MNG-7999] Cleanup [maven]

[via GitHub]

cstamas opened a new pull request, #1367:
URL: https://github.com/apache/maven/pull/1367

   This is an ongoing effort to perform a bit of cleanup in Maven Core and 
around. No logic changes, just removing unused members, redundant checks, etc.
   
   ---
   
   https://issues.apache.org/jira/browse/MNG-7999


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org