Re: [PR] [MRESOLVER-335] Proposal for better errors [maven-resolver]

2023-12-11 Thread via GitHub


cstamas merged PR #386:
URL: https://github.com/apache/maven-resolver/pull/386


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [MRESOLVER-335] Proposal for better errors [maven-resolver]

2023-12-09 Thread via GitHub


cstamas commented on PR #386:
URL: https://github.com/apache/maven-resolver/pull/386#issuecomment-1848597549

   Reworked it and is much simpler change (and is even backward compat, so no 
tampering with japicm needed)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [MRESOLVER-335] Proposal for better errors [maven-resolver]

2023-12-08 Thread via GitHub


cstamas commented on PR #386:
URL: https://github.com/apache/maven-resolver/pull/386#issuecomment-1847563980

   One thing am unsure about: `Map exceptions` 
in ArtifactResult... I think it should be `Map> exceptions` instead...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [MRESOLVER-335] Proposal for better errors [maven-resolver]

2023-12-08 Thread via GitHub


cstamas commented on PR #386:
URL: https://github.com/apache/maven-resolver/pull/386#issuecomment-1846798449

   @slawekjaranowski as reporter, anything to add?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] [MRESOLVER-335] Proposal for better errors [maven-resolver]

2023-12-04 Thread via GitHub


cstamas opened a new pull request, #386:
URL: https://github.com/apache/maven-resolver/pull/386

   Basically drop the method building text message (and build something very 
basic instead). It is the application that should build proper output, as it 
does have access to 
org.eclipse.aether.resolution.ArtifactResolutionException#getResults and can 
and should build meaningful error instead.
   
   ---
   
   https://issues.apache.org/jira/browse/MRESOLVER-335


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org