Re: [PR] Clean mdo schemas [maven]
gnodet merged PR #1365: URL: https://github.com/apache/maven/pull/1365 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Clean mdo schemas [maven]
gnodet commented on code in PR #1365: URL: https://github.com/apache/maven/pull/1365#discussion_r1447369717 ## api/maven-api-model/src/main/mdo/maven.mdo: ## @@ -572,15 +550,12 @@ dependencies 3.0.0+ - +See a href="https://maven.apache.org/guides/introduction/introduction-to-dependency-mechanism.html;>the Review Comment: Fixed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Clean mdo schemas [maven]
gnodet commented on code in PR #1365: URL: https://github.com/apache/maven/pull/1365#discussion_r1447326259 ## api/maven-api-model/src/main/mdo/maven.mdo: ## @@ -572,15 +550,12 @@ dependencies 3.0.0+ - +See a href="https://maven.apache.org/guides/introduction/introduction-to-dependency-mechanism.html;>the Review Comment: Ah, https://docs.oracle.com/javase/7/docs/technotes/tools/windows/javadoc.html#see -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Clean mdo schemas [maven]
gnodet commented on code in PR #1365: URL: https://github.com/apache/maven/pull/1365#discussion_r1447325048 ## api/maven-api-model/src/main/mdo/maven.mdo: ## @@ -572,15 +550,12 @@ dependencies 3.0.0+ - +See a href="https://maven.apache.org/guides/introduction/introduction-to-dependency-mechanism.html;>the Review Comment: Isn't `@see` to link to another javadoc element ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Clean mdo schemas [maven]
michael-o commented on code in PR #1365: URL: https://github.com/apache/maven/pull/1365#discussion_r1447257524 ## api/maven-api-model/src/main/mdo/maven.mdo: ## @@ -572,15 +550,12 @@ dependencies 3.0.0+ - +See a href="https://maven.apache.org/guides/introduction/introduction-to-dependency-mechanism.html;>the Review Comment: `@see`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Clean mdo schemas [maven]
elharo commented on code in PR #1365: URL: https://github.com/apache/maven/pull/1365#discussion_r1446077275 ## api/maven-api-plugin/src/main/mdo/lifecycle.mdo: ## @@ -18,20 +18,20 @@ under the License. --> http://codehaus-plexus.github.io/MODELLO/2.0.0; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; - xsi:schemaLocation="http://codehaus-plexus.github.io/MODELLO/2.0.0 http://codehaus-plexus.github.io/modello/xsd/modello-2.0.0.xsd; + xsi:schemaLocation="http://codehaus-plexus.github.io/MODELLO/2.0.0 https://codehaus-plexus.github.io/modello/xsd/modello-2.0.0.xsd; xml.namespace="http://maven.apache.org/LIFECYCLE/${version}; xml.schemaLocation="http://maven.apache.org/xsd/lifecycle-${version}.xsd;> lifecycle Lifecycle LifecycleConfiguration 1.0.0 - + Review Comment: CDATA no longer needed here -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org